fix(api): COALESCE cancel actor across canceled_by/cancelled_by

[cristim]

Summary

Cancel-actor attribution silently drops from the Purchase History UI whenever the cancelling actor was written to the newer canceled_by column but not the legacy cancelled_by one.

PR #1277 (expand-contract migration 000089) and its follow-up #1453 moved cancel-attribution writes to the canonical canceled_by column, but every SELECT in internal/config/store_postgres.go still projected the bare legacy cancelled_by column. CancelExecutionAtomic / CancelScheduledExecutionAtomic write only canceled_by, so any execution cancelled through those paths scanned back with cancelled_by = NULL and the History page lost the actor.

Fix

• Every read path (GetExecutionsByStatuses, GetPlannedExecutions, GetStaleApprovedExecutions, ListStuckExecutions, GetPendingExecutions, GetPendingExecutionsTx, GetExecutionByID, GetExecutionByPlanAndDate, GetScheduledExecutionsDue) now projects COALESCE(canceled_by, cancelled_by) AS cancelled_by, so a row written by either column round-trips correctly.
• SetCancelledBy now writes both canceled_by and the legacy cancelled_by column, keeping it symmetric with the atomic-cancel paths ahead of the planned contract migration (#1278) that drops the legacy column.
• Doc-comment cleanup: interfaces.go and handler_purchases_revoke.go update stale 'cancelled' references to the canonical 'canceled' (US spelling) status value used since fix(db): rename status value cancelled->canceled (expand-contract, US spelling) #1277/fix(db): write canonical 'canceled' on all cancel paths + cleanup filter (follow-up to #1277) #1453.

Test plan

• go build ./...
• go vet ./...
• go test ./internal/api/... ./internal/config/...
• golangci-lint run (CI-pinned v2.10.1)
• gocyclo -over 10 on changed files
• New pgxmock regression test (TestPGXMock_GetExecutionByID_ProjectsCoalescedCancelledBy) confirmed to FAIL against the pre-fix query (mock's regexp match on COALESCE(...) doesn't match the bare cancelled_by projection, so the query returns no rows) and PASS post-fix

Relates to #1277, #1453.

Summary by CodeRabbit

• Bug Fixes

  • Cancellation attribution is now saved and displayed consistently across current and legacy records.
  • Execution history and scheduled execution views correctly show who canceled an execution.
  • Cancellation status documentation now accurately reflects the transition to “canceled.”

• Tests

  • Added coverage to verify cancellation details are returned correctly when stored in the current cancellation field.

[cristim]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9fe53bdf-14a1-4f5c-82f5-1fe7cdef039a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Cancellation attribution now writes both current and legacy columns, while all purchase-execution readers coalesce those values. Cancellation documentation uses the canceled status spelling, and a pgxmock test covers direct execution lookup.

Changes

Cancellation attribution compatibility

Layer / File(s)	Summary
Cancellation status and attribution contracts internal/api/handler_purchases_revoke.go, internal/config/interfaces.go	Documentation now uses canceled for cancellation transitions and describes stamping both attribution columns.
Cancellation attribution storage and reads internal/config/store_postgres.go, internal/config/store_postgres_pgxmock_test.go	SetCancelledBy updates both columns, readers use COALESCE(canceled_by, cancelled_by), and a pgxmock test verifies populated attribution.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

• LeanerCloud/CUDly#1255: Both modify SQL projections for planned execution reads and related pgxmock coverage.
• LeanerCloud/CUDly#1277: Both align cancellation spelling and support current/legacy cancellation attribution fields.

Suggested labels: effort/m

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: coalescing cancel-actor attribution across the canonical and legacy columns.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/1277-coalesce-cancelled-by-readside

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/config/store_postgres.go`:
- Around line 1043-1047: Update PostgresStore.SetCancelledBy to append the
cancellation-attribution event instead of directly executing the
purchase_executions UPDATE. Add or reuse the event projection handler to set
both canceled_by and cancelled_by compatibility columns, ensuring the event
stream is the source of truth for this state change.

🪄 Autofix (Beta)

❌ Autofix failed (check again to retry)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 04d84b85-0e72-4f1d-ab90-0536b9a33df0

📥 Commits

Reviewing files that changed from the base of the PR and between 1cc33d3 and 662472a.

📒 Files selected for processing (4)

• internal/api/handler_purchases_revoke.go
• internal/config/interfaces.go
• internal/config/store_postgres.go
• internal/config/store_postgres_pgxmock_test.go

[coderabbitai]

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

The agent ran but didn't make any changes. The issues may already be fixed or require manual intervention.