Skip to content

fix(frontend/mobile): add inputmode/autocomplete hints to remaining form inputs (closes #986) - #1498

Merged
cristim merged 1 commit into
mainfrom
fix/986-form-input-hints
Jul 23, 2026
Merged

cristim merged 1 commit into
mainfrom
fix/986-form-input-hints

Conversation

@cristim

@cristim cristim commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

  • PR feat(frontend/mobile): viewport + touch-target + safe-area foundations #989 already added inputmode="numeric" to number fields and autocomplete="email" to the notification email field.
  • This PR covers the remaining gaps from mobile: numeric inputs lack inputmode; email/password inputs lack autocomplete #986:
    • Remaining type=email fields (user email, contact email, GCP client email, profile email, reset email, login/setup email): add autocomplete="email" autocapitalize="none" autocorrect="off".
    • type=password fields (user create, profile current password, AWS secret key, Azure client secret, setup API key): add the appropriate autocomplete value (new-password / current-password / off for non-account secrets).
    • Text inputs for API keys / ARNs / client IDs: add autocapitalize="none" autocorrect="off" spellcheck="false".
    • Percentage-based number fields (coverage %): change inputmode from numeric to decimal; day/hour count fields keep numeric and gain autocomplete="off".

Test plan

  • npx tsc --noEmit clean
  • npx jest full affected suite (13 suites, 800 tests) passes, including html.test.ts

… to remaining form inputs (closes #986)

Adds autocomplete="email"/autocapitalize="none"/autocorrect="off" to
remaining email fields, autocomplete hints to password fields, decimal
inputmode to percentage-based number fields, and
autocapitalize/autocorrect/spellcheck suppression to API key and ARN
text inputs, so mobile keyboards and browser autofill behave correctly.
@cristim cristim added bug Something isn't working triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/this-quarter Within the quarter impact/many Affects most users labels Jul 22, 2026
@cristim

cristim commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 84dbe82b-1d6b-429b-8cef-b3805ee2bc58

📥 Commits

Reviewing files that changed from the base of the PR and between 70c9a7b and 1974f28.

📒 Files selected for processing (2)
  • frontend/src/auth.ts
  • frontend/src/index.html
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/986-form-input-hints

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim cristim added severity/medium Moderate harm effort/xs Trivial / one-liner type/bug Defect and removed severity/low Minor harm labels Jul 22, 2026
@cristim
cristim merged commit 294892d into main Jul 23, 2026
21 checks passed
@cristim
cristim deleted the fix/986-form-input-hints branch July 27, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working effort/xs Trivial / one-liner impact/many Affects most users priority/p3 Polish / idea / may never ship severity/medium Moderate harm triaged Item has been triaged type/bug Defect urgency/this-quarter Within the quarter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant