Skip to content

fix(iac/aws): create_before_destroy on OIDC signing key (follow-up to #1480) #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Jul 27, 2026
Merged

fix(iac/aws): create_before_destroy on OIDC signing key (follow-up to #1480) #1512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions terraform/modules/compute/aws/lambda/signing-key.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ resource "aws_kms_key" "signing" {
tags = merge(var.tags, {
Name = "${var.stack_name}-oidc-signing"
})

# Any change that forces a new CMK (e.g. the RSA_2048 -> ECC_NIST_P256
# migration in #1480) must create the replacement key and cut the alias
# over to it BEFORE scheduling the old key for deletion. Without this,
# Terraform's default destroy-before-create would schedule the live OIDC
# signing key for deletion (immediately unusable for kms:Sign) before the
# new key exists, briefly breaking client-assertion JWT minting.
lifecycle {
create_before_destroy = true
}
}

resource "aws_kms_alias" "signing" {
Expand Down
Loading