Skip to content

ci: align vet and lint with module loop convention - #2126

Merged
cristim merged 1 commit into
mainfrom
ci/1478-module-loops
Sep 30, 2026
Merged

cristim merged 1 commit into
mainfrom
ci/1478-module-loops

Conversation

@cristim

@cristim cristim commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Align vet and golangci-lint with the workflow's existing for mod in . convention. The CLI has one module today, so this is a consistency change with unchanged analysis coverage. Future modules still require explicit loop updates.

Keep the pinned lint action as installer, its cache path, configuration verification, and ten-minute timeout. Only .github/workflows/ci.yml changes.

Validation on macOS with Go 1.26.6 and golangci-lint 2.10.1:

  • Real pre-edit vet/lint baseline and exact edited YAML blocks passed; stdout/stderr match byte-for-byte after removing only the added banners. Action wrapper grouping/annotations are not claimed identical.
  • Five supplemental shell fixtures verify success, config failure stopping lint, lint failure, vet success/failure, exact arguments, root cwd, and cache path.
  • Pinned workflow hooks, native actionlint, race-short suite (522.128s), CLI build, and help passed.
  • The bounded act dry-run stopped while fetching actions; it provides no successful runner simulation. Hosted Linux checks remain required.

Independent review: gpt-6-astra, using the user-authorized substitute and local review path, completed three clean plan passes and two clean implementation passes. Final verdict: APPROVED for publication at 1321c11f7af6fd02a67e67bf28dab50c69c5256a, no actionable findings. Reviewer reread the full committed diff, verified the clean tree and workflow byte identity, and reran independent YAML probes and actionlint. Merge remains conditional on required hosted checks.

Closes #1478

Summary by CodeRabbit

  • Chores
    • Updated automated checks to verify lint configuration and run linting and Go vet checks across each module. No user-facing changes.

@cristim cristim added triaged Item has been triaged priority/p1 Next up; this sprint severity/high Significant harm urgency/this-sprint Within the current sprint impact/all-users Affects every user effort/m Days type/chore Maintenance / non-user-visible labels Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 18e8e0b1-3476-4c7e-ba78-a334559d09a3

📥 Commits

Reviewing files that changed from the base of the PR and between 911dc5d and 1321c11.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The CI workflow now installs the pinned golangci-lint version, verifies its configuration, and runs lint and go vet for each listed module.

Changes

CI code checks

Layer / File(s) Summary
Run lint and vet for modules
.github/workflows/ci.yml
The lint step verifies the configuration and runs golangci-lint with a 10-minute timeout for each listed module. The vet step runs go vet ./... in a loop over the listed modules.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~7 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 1321c

The lint and vet workflow changes have no established merge-blocking issue. Complete the hosted Linux checks as part of normal validation.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main CI change: aligning vet and lint commands with the existing module loop convention.
Linked Issues check ✅ Passed PR #2126 meets the coding requirements in #1478. .github/workflows/ci.yml changes go vet ./... to the for mod in . pattern. It changes the lint job to install the pinned action separately and ru…
Out of Scope Changes check ✅ Passed The changes stay within #1478. The PR changes only .github/workflows/ci.yml and updates the two requested CI checks. The lint installer split, configuration verification, cache setup, timeout preser…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@cristim
cristim merged commit 93b9b6d into main Sep 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/m Days impact/all-users Affects every user priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/chore Maintenance / non-user-visible urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: go vet/lint steps don't use the per-module loop convention [cli part]

1 participant