Skip to content

fix(cli): correct dry-run purchase guidance - #2127

Merged
cristim merged 1 commit into
mainfrom
fix/dry-run-commitment-footer
Sep 30, 2026
Merged

cristim merged 1 commit into
mainfrom
fix/dry-run-commitment-footer

Conversation

@cristim

@cristim cristim commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Dry runs incorrectly said Savings Plans purchasing was unimplemented, even though the purchase path supports it. Remove that claim and refer to the proposed purchases as commitments so the guidance also covers Savings Plans.

Closes #1945

Verification on ebc0eeeea271061fe1e1a50b6239af6e7a0e32e5:

  • Actual macOS CLI executions with RI-only and mixed RI/Savings Plans CSV inputs printed the corrected footer and produced dry-run report rows. Baseline executions reproduced the stale disclaimer. Synthetic inputs and closed loopback AWS endpoints were used; no live-cloud recommendations or purchases were exercised. The existing CSV parser does not reconstruct Savings Plans details, so these cases verify footer execution, not purchase suitability.
  • Focused summary/footer race tests, pinned Go 1.26.6 build, and normal commit hooks passed. Full go test -race -short ./... passed with localhost listener permission.
  • Independent gpt-6-astra adversarial review, explicitly authorized for this session, completed two implementation passes and exact-SHA verification with no actionable findings. The reviewer rebuilt the committed CLI, confirmed vcs.modified=false, and independently repeated both command scenarios. This local review is the chosen review gate in place of CodeRabbit; CI must pass on the same SHA before merge.

The actual-purchase branch and all purchase routing are unchanged.

Summary by CodeRabbit

  • Updates
    • Dry-run purchase instructions now refer to “commitments” instead of “RIs.”
    • Removed the note that Savings Plans purchasing is not yet implemented.

Describe proposed purchases as commitments and remove the obsolete
Savings Plans unimplemented warning.
@cristim cristim added triaged Item has been triaged priority/p1 Next up; this sprint severity/medium Moderate harm urgency/this-sprint Within the current sprint impact/few Limited audience effort/xs Trivial / one-liner type/bug Defect labels Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: b706908d-9e8d-4604-9d2b-93c68bc78816

📥 Commits

Reviewing files that changed from the base of the PR and between 93b9b6d and ebc0eee.

📒 Files selected for processing (1)
  • cmd/multi_service_stats.go

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The dry-run purchase instruction now refers to commitments instead of RIs. The footer no longer says that Savings Plans purchasing is not implemented.

Changes

Dry-run message

Layer / File(s) Summary
Update dry-run footer text
cmd/multi_service_stats.go
The purchase instruction now refers to commitments instead of RIs. The Savings Plans note was removed.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to ebc0e

The dry-run message no longer incorrectly says Savings Plans purchasing is unavailable. No actionable merge risk remains in this text change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: correcting dry-run purchase guidance in the CLI.
Linked Issues check ✅ Passed The change satisfies issue #1945. In cmd/multi_service_stats.go, the dry-run footer now refers to purchasing these “commitments” and removes the false statement that Savings Plans purchasing is not …
Out of Scope Changes check ✅ Passed The reviewed change is limited to the dry-run footer in cmd/multi_service_stats.go. It directly supports issue #1945 by correcting the purchase guidance. No unrelated implementation change is shown.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@cristim
cristim merged commit f2a3fe2 into main Sep 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/few Limited audience priority/p1 Next up; this sprint severity/medium Moderate harm triaged Item has been triaged type/bug Defect urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): the dry-run footer says Savings Plans purchasing is not implemented, but it is

1 participant