Skip to content

test(purchase): stub RecoverStrandedApprovals late-completion mock to fix panic #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
May 22, 2026
Merged

test(purchase): stub RecoverStrandedApprovals late-completion mock to fix panic #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/purchase/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,12 @@ func TestManager_RecoverStrandedApprovals_LateCompletionNotClobbered(t *testing.
Return([]config.PurchaseExecution{stranded}, nil)
mockStore.On("TransitionExecutionStatus", ctx, "exec-raced", []string{"approved"}, "failed").
Return(nil, errors.New("execution exec-raced cannot transition from \"completed\" to \"failed\""))
// When TransitionExecutionStatus fails the manager calls GetExecutionByID to
// distinguish a race (row already left "approved") from a real store error.
// Returning a "completed" row causes RecoverStrandedApprovals to skip the
// execution, which is the behaviour this test asserts.
mockStore.On("GetExecutionByID", ctx, "exec-raced").
Return(&config.PurchaseExecution{ExecutionID: "exec-raced", Status: "completed"}, nil)

manager := &Manager{config: mockStore, dashboardURL: "https://dashboard.example.com"}

Expand Down
Loading