Repository navigation
test(config): add approval_token_expires_at column to pgxmock GetExecutionByID rows - #664
Conversation
… rows
The production queryExecutions scan reads 22 columns; the mock row
definitions in TestPGXMock_GetExecutionByID_Success and
TestPGXMock_GetExecutionByID_WithTimestamps only declared 21, causing
"incorrect argument number 22 for columns 21" at scan time.
Add "approval_token_expires_at" as the 22nd column (after
retry_attempt_n, matching the SELECT and rows.Scan order in
store_postgres.go) and supply sql.NullTime{} as its value in both rows.
Closes #627, Closes #624
cristim
added
triaged
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
1 participant
Closes #627, Closes #624. The production queryExecutions scan reads 22 columns (approval_token_expires_at as the last, into sql.NullTime) but the pgxmock test rows declared only 21, failing with 'incorrect argument number 22 for columns 21'. Adds the missing column + value to both GetExecutionByID test funcs. Full internal/config package green (499 tests).