Repository navigation
Conversation
PR #478 aggregated per-provider grace validation into one toast; the test assertions still expected the old per-provider wording, causing a pre-existing CI failure on feat/multicloud-web-frontend. PR #548 updated the assertions to match. Add a history note in the file header so the next reader understands why the expected message format is aggregated.
|
Warning Review limit reached
More reviews will be available in 6 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai full review |
Rate Limit Exceeded
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Summary
settings-purchasing-grace.test.tsbefore the fix):expect(toastArg.message).toBe('AWS grace period: Must be a whole number between 0 and 30')-- the test expected the old per-provider toast wording.saveGlobalSettingsto aggregate all failing grace-period providers into a single toast (Grace period must be a whole number between 0 and 30 days (AWS).). Commit1c92887be(PR fix(ux/settings): inline range validation on numeric settings inputs #471 follow-up) added the inline-validation tests but carried the stale per-provider assertion from the pre-ux(settings): grace-period validation message only names the first failing provider when multiple are bad #478 design.508704a79) already updated the assertions to match the aggregated format. The fix is test-side: the production code (saveGlobalSettings) is correct and emits the aggregated message as designed by ux(settings): grace-period validation message only names the first failing provider when multiple are bad #478.Test counts
17 passed, 0 failed (
npx jest src/__tests__/settings-purchasing-grace.test.ts).npx tsc --noEmitclean.Closes #514