chore(providers/aws): periodic audit of findOfferingID across 7 services (closes #515) by cristim · Pull Request #815 · LeanerCloud/cloud-commitments-cli

cristim · 2026-05-28T18:29:24Z

Summary

Quarterly audit of all 7 AWS service clients' findOfferingID (EC2, RDS, ElastiCache, MemoryDB, OpenSearch, Redshift, SavingsPlans) against the contract established in PR fix(purchases): narrow Describe*Offerings + cap pagination (#688) #690: typed fields, ctx.Err() check, page cap, per-page log, variant soft-skip, nil+empty token terminator.
All 7 services PASS all contract items. Three pre-existing test bugs (missing execID arg in RDS, Redshift, SavingsPlans test calls) are fixed.
New providers/aws/services/AUDIT.md documents the 6-item contract, per-service status table, watchlist (MemoryDB Valkey engine split, OpenSearch/Redshift Graviton dimension), and quarterly audit procedure.
Added TestFindOfferingID_CtxCancelledBeforePage and TestFindOfferingID_EmptyStringTokenEndsPagination to every service's test file (14 new tests across 7 packages) to pin contract items C2 and C6 against future regressions.

Test plan

go test ./providers/aws/services/... -- 319 tests pass across all 7 packages
go build ./... -- clean
Review providers/aws/services/AUDIT.md for completeness and accuracy
Verify new tests fail when the contract is artificially broken (ctx check or token check removed)

cristim · 2026-05-28T18:29:30Z

@coderabbitai review

coderabbitai · 2026-05-28T18:29:32Z

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b5d8cda8-2ef6-476b-8b39-235101489928

📥 Commits

Reviewing files that changed from the base of the PR and between 5c267c5 and 0cb9cbf.

📒 Files selected for processing (8)

providers/aws/services/AUDIT.md
providers/aws/services/ec2/client_test.go
providers/aws/services/elasticache/client_test.go
providers/aws/services/memorydb/client_test.go
providers/aws/services/opensearch/client_test.go
providers/aws/services/rds/client_test.go
providers/aws/services/redshift/client_test.go
providers/aws/services/savingsplans/client_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/515-wave6

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-05-28T18:29:35Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-05-30T10:22:30Z

@coderabbitai full review

coderabbitai · 2026-05-30T10:22:35Z

✅ Actions performed

Full review triggered.

cristim · 2026-06-04T14:04:28Z

@coderabbitai review

coderabbitai · 2026-06-04T14:04:36Z

Rate Limit Exceeded

@cristim have exceeded the limit for the number of chat messages per hour. Please wait 38 minutes and 59 seconds before sending another message.

cristim · 2026-06-05T11:01:29Z

Rebased on feat/multicloud-web-frontend. Resolved additive conflicts in providers/aws/services/ec2/client_test.go and providers/aws/services/redshift/client_test.go (HEAD added Name-tag tests from #687, PR adds context-cancellation and empty-token pagination tests for #515; both kept).

cristim · 2026-06-05T11:01:46Z

@coderabbitai review

coderabbitai · 2026-06-05T11:01:51Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-06-08T07:18:35Z

@coderabbitai full review

coderabbitai · 2026-06-08T07:18:41Z

✅ Action performed

Full review finished.

cristim · 2026-06-19T15:52:03Z

@coderabbitai review

coderabbitai · 2026-06-19T15:52:10Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-07-09T21:19:59Z

@coderabbitai review

coderabbitai · 2026-07-09T21:20:05Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-07-10T14:48:51Z

@coderabbitai review

coderabbitai · 2026-07-10T14:48:57Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Add context-cancellation and empty-NextToken pagination tests for findOfferingID across 7 AWS services (EC2, ElastiCache, MemoryDB, OpenSearch, RDS, Redshift, SavingsPlans). Also adds AUDIT.md recording the audit findings and pagination contract. Resolves conflict with main's TestPurchaseCommitment_TagFailure_StructuredLog by including both that test and the new findOfferingID tests.

cristim · 2026-07-19T19:58:57Z

Rebased onto origin/main, all CI checks passed, squash-merged.

cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/this-quarter Within the quarter impact/internal Team-internal only effort/s Hours type/chore Maintenance / non-user-visible labels May 28, 2026

cristim force-pushed the fix/515-wave6 branch from 8962850 to 3a193f6 Compare June 5, 2026 11:01

cristim force-pushed the fix/515-wave6 branch from 3a193f6 to 62a6963 Compare June 8, 2026 04:20

cristim changed the base branch from feat/multicloud-web-frontend to main June 9, 2026 15:45

cristim force-pushed the fix/515-wave6 branch from 62a6963 to 937dde7 Compare June 19, 2026 15:50

cristim mentioned this pull request Jun 19, 2026

fix(providers/aws): getDurationString/getDurationValue silently fallback to 1yr on unrecognized term #1266

Closed

cristim force-pushed the fix/515-wave6 branch from 937dde7 to 8004a8b Compare July 10, 2026 14:48

cristim force-pushed the fix/515-wave6 branch 2 times, most recently from 82a4251 to dd69c33 Compare July 17, 2026 18:35

cristim force-pushed the fix/515-wave6 branch from dd69c33 to 0cb9cbf Compare July 19, 2026 18:51

cristim merged commit 0f7d0fe into main Jul 19, 2026
19 checks passed

cristim deleted the fix/515-wave6 branch July 27, 2026 11:09

Conversation

cristim commented May 28, 2026

Summary

Test plan

Uh oh!

cristim commented May 28, 2026

Uh oh!

coderabbitai Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

coderabbitai Bot commented May 28, 2026

Uh oh!

cristim commented May 30, 2026

Uh oh!

coderabbitai Bot commented May 30, 2026

Uh oh!

cristim commented Jun 4, 2026

Uh oh!

coderabbitai Bot commented Jun 4, 2026

Rate Limit Exceeded

Uh oh!

cristim commented Jun 5, 2026

Uh oh!

cristim commented Jun 5, 2026

Uh oh!

coderabbitai Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jun 8, 2026

Uh oh!

coderabbitai Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jun 19, 2026

Uh oh!

coderabbitai Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jul 9, 2026

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cristim commented Jul 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented May 28, 2026 •

edited

Loading

coderabbitai Bot commented Jun 5, 2026 •

edited

Loading

coderabbitai Bot commented Jun 8, 2026 •

edited

Loading

coderabbitai Bot commented Jun 19, 2026 •

edited

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading