Skip to content

ux(frontend): list per-plan-type SP breakdown in plan summary (closes #248) #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cristim wants to merge 1 commit into from
Closed

ux(frontend): list per-plan-type SP breakdown in plan summary (closes #248) #824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions frontend/src/__tests__/plans.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,66 @@ describe('Plans Module', () => {
expect(list?.innerHTML).not.toContain('Multiple');
});

test('three-SP plan summary lists all three plan types comma-joined (issue #248)', async () => {
// Regression guard for issue #248: a plan targeting Compute SP,
// EC2 Instance SP, and SageMaker SP must show all three labels in
// the Service detail row of the plan card, comma-joined, rather
// than collapsing to just the first entry.
(api.getPlans as jest.Mock).mockResolvedValue({
plans: [
{
id: 'plan-three-sp',
name: 'Three SP plan',
enabled: true,
auto_purchase: true,
services: {
'aws:savings-plans-compute': {
provider: 'aws',
service: 'savings-plans-compute',
enabled: true,
term: 3,
payment: 'no-upfront',
coverage: 80,
},
'aws:savings-plans-ec2instance': {
provider: 'aws',
service: 'savings-plans-ec2instance',
enabled: true,
term: 3,
payment: 'no-upfront',
coverage: 80,
},
'aws:savings-plans-sagemaker': {
provider: 'aws',
service: 'savings-plans-sagemaker',
enabled: true,
term: 3,
payment: 'no-upfront',
coverage: 80,
},
},
ramp_schedule: {
type: 'immediate',
percent_per_step: 100,
step_interval_days: 0,
current_step: 0,
total_steps: 1,
},
},
],
});
(api.getPlannedPurchases as jest.Mock).mockResolvedValue({ purchases: [] });

await loadPlans();

const list = document.getElementById('plans-list');
expect(list?.innerHTML).toContain('Compute SP');
expect(list?.innerHTML).toContain('EC2 Instance SP');
expect(list?.innerHTML).toContain('SageMaker SP');
// All three labels must appear together in the same Service detail value.
expect(list?.innerHTML).toMatch(/Compute SP.*EC2 Instance SP.*SageMaker SP/);
});

test('single-service plan still renders one label (no regression)', async () => {
(api.getPlans as jest.Mock).mockResolvedValue({
plans: [
Expand Down
Loading