Skip to content

ux(settings): toast-undo for Reset on override rows (closes #113) - #834

Merged
cristim merged 1 commit into
feat/multicloud-web-frontendfrom
fix/113-wave11
Jun 3, 2026
Merged

cristim merged 1 commit into
feat/multicloud-web-frontendfrom
fix/113-wave11

Conversation

@cristim

@cristim cristim commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

  • After a confirmed Delete on an override row, snapshot all fields (term, payment, coverage, enabled, ramp_schedule, include/exclude arrays) before the API call.
  • On success, show a 5-second info toast: "Override for aws/rds deleted." with an Undo button.
  • Clicking Undo re-PUTs the snapshot via saveAccountServiceOverride, reloads the panel, and refreshes recommendations -- restoring the row exactly as it was.
  • No changes to toast.ts -- actions[] already existed.

Test plan

  • settings-accounts.test.ts: "Delete shows info toast with Undo action and clears row (click-Undo path)" -- verifies toast shape, 5s TTL, and saveAccountServiceOverride called with original values on Undo.
  • settings-accounts.test.ts: "let-it-expire path: override is permanently gone after toast timeout" -- verifies saveAccountServiceOverride is NOT called when Undo is not clicked.
  • npx tsc --noEmit clean.
  • Full jest suite: 2144 pass, 0 fail.

After confirming delete, snapshot all override fields before calling the
API. On success, show a 5-second info toast with an Undo action; clicking
Undo re-PUTs the snapshot and reloads the panel.

No changes to toast.ts -- actions[] already supported.
@cristim cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline impact/few Limited audience effort/s Hours type/feat New capability labels May 28, 2026
@cristim

cristim commented May 28, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 28, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 62 minutes and 34 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 16ece946-c380-42ca-b001-492dc7babbfa

📥 Commits

Reviewing files that changed from the base of the PR and between 4956d66 and efe3a61.

📒 Files selected for processing (2)
  • frontend/src/__tests__/settings-accounts.test.ts
  • frontend/src/settings.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/113-wave11

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented May 30, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Full review triggered.

@cristim

cristim commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

pr-iterate: CR appears to be blocked by org-level usage limits (most recent CR comment includes "Your organization has run out of usage credits"; subsequent @coderabbitai full review ping at 2026-05-30T10:22Z produced only a "Review triggered" ack with no substantive review after ~4.5 days). This PR is otherwise merge-ready (mergeStateStatus=CLEAN, all CI checks green). Re-invoke /pr-iterate 834 after the org's CR billing is topped up to get a substantive CR pass. To clear the wave-level marker after billing is fixed: rm ~/.claude/agent-comms/cr-rate-limit-deadline.txt.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

@cristim: Acknowledged — triggering a full review now. Apologies for the earlier disruption caused by the usage limit issue.


🧠 Learnings used
Learnt from: cristim
Repo: LeanerCloud/CUDly PR: 0
File: :0-0
Timestamp: 2026-05-05T15:44:54.463Z
Learning: In the LeanerCloud/CUDly repository, when a CodeRabbit review flags something as "outside-diff" that was already implemented in an earlier commit of the same PR, it is likely a stale-snapshot artifact where the review diff was generated against a pre-fix view. The inline comment convention `(CR pass on PR #<number> Finding N)` is used by the maintainer (cristim) to mark lines that were changed in direct response to a prior CodeRabbit review pass.
✅ Action performed

Full review finished.

@cristim
cristim merged commit 1591ce5 into feat/multicloud-web-frontend Jun 3, 2026
5 checks passed
@cristim
cristim deleted the fix/113-wave11 branch June 3, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/few Limited audience priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/feat New capability urgency/eventually No deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant