Skip to content

fix(elasticache): empty engine fails dedupe open; Redis OSS RIs covering Valkey recs aren't deduped #150

Description

@cristim

Follow-ups from the review of #149 (closes #66):

  • providers/aws/services/elasticache/client.go ~100: a reservation with a nil ProductDescription gets Engine "", so its dedupe key never matches and the check fails open. Log a warning, and treat an empty engine as matching any engine for the cache service (fail closed).
  • AWS lets Redis OSS reserved nodes cover Valkey nodes. A manually bought Redis RI won't dedupe a 'valkey' recommendation. Normalize redis and valkey to one engine family for ElastiCache dedupe.
  • Nit: memorydb/client_test.go claims to catch parser drift but hardcodes 'redis' instead of building the rec through parseMemoryDBDetails.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions