Skip to content

fix(deps): align provider module pkg pins with nullable Cost API #154

Description

@cristim

Provider modules at library main ce95136 still select a published shared pkg version with scalar PurchaseResult.Cost, while their source now assigns *float64 after #151. The repository workspace hides this mismatch by selecting local pkg.

Reproduction: with Go 1.26.6, enter providers/gcp and run GOWORK=off go build ./.... It fails in services/computeengine/client.go at the Cost assignment: cannot use &rec.CommitmentCost (value of type *float64) as float64 value in assignment. Independent AWS standalone checks during #145 and #150 verification fail on the equivalent pointer assignments. Workspace checks pass. This affects consumers that select a provider without explicitly upgrading pkg alongside it; the CLI/MCP coordinated four-module pins avoid it.

Expected: every published provider module builds and tests with GOWORK=off using its declared dependencies. Update providers/aws/go.mod+go.sum, providers/azure/go.mod+go.sum, and providers/gcp/go.mod+go.sum to a published pkg revision containing the required shared APIs, with no replace/vendor workaround. Verify standalone module build/test/tidy and at least one external consumer importing only a provider. Add an appropriately scoped CI check if the existing matrix only exercises go.work.

Sequence the pin after the shared-package changes it requires are published; #144 and #150 also change shared deduplication behavior and should be included before the next coordinated consumer refresh.

References: #151, #144, #145, #150, #153; discovered during the 2026-09-29 handover verification. Severity high: a published dependency combination does not compile. No cloud or production changes required.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions