test(aws): preserve requested-window SP coverage rates - #168
Merged
Merged
Conversation
Verify sparse and explicit-zero days produce identical hourly rates, including paginated and nil-coverage responses. Clarify that Days does not certify reporting completeness or alter the requested-window divisor. Refs #51
Contributor
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 10 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 70 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Comment |
Preserve the reviewed Savings Plans contract regression while including the merged RI coverage aggregation fix from main.
Include the merged storage pricing change without rewriting the reviewed Savings Plans contract regression or published branch history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Savings Plans hourly rates normalize reported totals over the requested window. Counting only returned coverage blocks would inflate rates for valid sparse usage: 240USD across a 30-day window is 1/3USD/hour whether 20 inactive days are omitted or explicitly zero.
Add the sparse/explicit-zero/nil regression, including pagination, and clarify the exported rate and Days comments. No production calculation changes. Refs #51, specifically the independently reviewed A07-019 disposition. Reporting completeness cannot be inferred from this endpoint's missing days.
Issue #51 remains open while the separate RI fix in #167 and the reporting-completeness disposition are completed. The recorded semantic decision retains the full-window divisor. The fixture cannot establish whether an omitted live period means zero activity or delayed reporting; no new live incomplete-data defect is claimed.
Verification: recommendations race suite, AWS build, pinned lint2.10.1 and normal hooks pass. An intentional Days-based divisor mutation fails the new regression at 1 versus 1/3USD/hour. A real AWS SDK/local HTTP fixture confirms equal requested-window rates for sparse and explicit-zero responses; no live AWS calls.
Independent gpt-6-astra review approved final integrated commit
cd4aa1286951dbf70e0b1ba413c7a61b0349291c: clean checkout and parent verification, full main-relative diff reread, GCP files identical to main28efbcd, fresh AWS RI/SP and GCP consumer race tests, and real SDK/local HTTP experiment. Additive merges preserve the original SP commit19dba433cc6db5b63978b2b14dfe5b2c81fcc96d; the SP contract files are unchanged. The reviewer independently confirmed that the Days-based mutation fails the intended rate assertions. Explicit normal hooks on the SP and incoming GCP files passed. This is the user-authorized independent review path; CodeRabbit is optional.