Skip to content

feat(social): show title and creator byline without repetition - #69

Merged
Leftium merged 1 commit into
mainfrom
continuum/social-preview-byline
Oct 21, 2026
Merged

Leftium merged 1 commit into
mainfrom
continuum/social-preview-byline

Conversation

@Leftium

@Leftium Leftium commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

This PR follows the Continuum protocol at 9aea333.

Summary

Keep social sharing cards concise while preserving the original video title, creator credit, and YouLoop branding.

  • Video og:title, Twitter title, and HTML title are the original YouTube title, without the - YouLoop suffix.
  • Video descriptions are by <creator> · YouLoop when an oEmbed author exists, or YouLoop otherwise.
  • Do not repeat the title or upstream description in the social byline.
  • Keep og:site_name, thumbnails, canonical URL normalization, generic fallback metadata, and the picker response unchanged.

Verification

  • Updated existing Node metadata tests for exact title/byline, author truncation and missing-author fallback, upstream description exclusion, and escaped social head tags.
  • Updated the existing SSR social smoke assertion for the new title and description format.
  • No new routine browser tests; existing metadata and smoke checks are appropriate, with no obsolete additional coverage retained.
  • Reviewed correctness and cleanup at 54ab0349f1be60a69c3ab8fcf5d5afe46ebd769e; no actionable findings or code changes were needed.
  • Local checks passed: pnpm check (zero errors/warnings), pnpm lint, pnpm test:clip (36), pnpm test:share-url (24), pnpm test:metadata (18), YOULOOP_RUNTIME_PROOF=1 pnpm build, and pnpm test:browser (36 Chromium/WebKit executions).
  • Production-mode preview passed test:hosting (7) and test:social (9). Social smoke also passed with REQUIRE_VIDEO_METADATA=1, exercising live video titles and creator bylines rather than generic fallback.
  • GitHub hosting verification and Vercel Preview passed at the same head.
  • Broader advisory browser cases and the separate frame/timeline proofs were not run for this metadata-only change. Existing tests were updated in place; no tests were added or retired.

Follow-up

  • Validate a fresh social card in the messaging app shown in the screenshot (some platforms cache Open Graph cards; a stale unfurl is inconclusive).
  • Maintain maintainer-controlled merge.

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
youloop Ready Ready Preview Oct 21, 2026 11:23am UTC

@Leftium

Leftium commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

This PR was claimed

@Leftium

Leftium commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

This PR's claim 6314783644 was released at 54ab034

@Leftium
Leftium marked this pull request as ready for review October 21, 2026 11:28
@Leftium
Leftium merged commit d8fcd93 into main Oct 21, 2026
3 checks passed
@Leftium
Leftium deleted the continuum/social-preview-byline branch October 21, 2026 11:33

This branch was successfully deployed

1 active deployment
Preview — 54ab0349 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant