Loading Libraries per default via CDN, e.g. GoogleFonts is possibly problematic with european GDPR.#888
Conversation
|
Good idea but please follow https://www.conventionalcommits.org/ |
Done :) |
|
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
|
This PR was closed because it has been marked stale for 15 days with no activity. If this PR is still valid, please re-open. |
There was a problem hiding this comment.
Pull request overview
This PR changes the default configuration so LibreBooking prefers loading bundled (local) JavaScript libraries instead of CDN-hosted ones by default, aligning with privacy/GDPR concerns for new installations and example setups.
Changes:
- Flip
use.local.js.libsdefault totruein the distributed config template. - Update documentation to show
use.local.js.libsenabled in the example. - Update
.env.examplesoLB_USE_LOCAL_JS_LIBSdefaults totrue.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/source/ADVANCED-CONFIGURATION.rst | Updates the documented example to enable local JS libraries. |
| config/config.dist.php | Changes the distributed default setting to prefer local JS libraries. |
| .env.example | Changes the example env var default to prefer local JS libraries. |
You can also share your feedback on Copilot code review. Take the survey.
|
Thanks @Steffeng5 Sorry this fell off my radar. I will work on this over the next few days. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 28 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 28 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
Loading Libraries per default via CDN, e.g. GoogleFonts is possibly problematic with European GDPR.
Allow usage of the vendored local copy of the Select2 library. Before it was always fetched from the CDN. Update the vendored Select2 4.0.5 library with 4.1.0-rc.0 and update the local references used when `use.local.js.libs` is enabled.
Add vendored Hind font assets and metadata, remove the global Google Fonts import from librebooking.css, and load the local font stylesheet when `use.local.js.libs` is enabled.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 29 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
@Steffeng5 Thanks for the PR
To ensure "Libre" in "LibreBooking" it would be better to serve JS libs by default from local :)