Skip to content

🐛 fix: Include Nested Paths in Config Validation Errors #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny-avila merged 1 commit into from
Aug 25, 2026
Merged

🐛 fix: Include Nested Paths in Config Validation Errors #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/server/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,6 +1330,18 @@ describe('validateFieldValue for endpoints', () => {
expect(result).toEqual({ success: true });
});

it('includes the full path for nested array validation errors', () => {
const result = validateFieldValue('endpoints.custom', [
validEndpoint,
{ ...validEndpoint, models: { fetch: true } },
]);

expect(result).toEqual({
success: false,
error: 'endpoints.custom[1].models.default: Required',
});
});

it('gracefully handles unknown deep paths', () => {
const result = validateFieldValue('endpoints.custom.0.nonexistent.deep', 'value');
expect(result).toEqual({ success: true });
Expand Down
11 changes: 9 additions & 2 deletions src/server/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,14 @@ export function validateFieldValue(
}
).safeParse(value);
if (!result.success && result.error) {
const messages = result.error.issues.map((i) => i.message);
const messages = result.error.issues.map((issue) => {
const issuePath = issue.path.reduce(
(path, segment) =>
typeof segment === 'number' ? `${path}[${segment}]` : `${path}.${segment}`,
fieldPath,
);
return `${issuePath}: ${issue.message}`;
});
return { success: false, error: messages.join('; ') || 'Validation failed' };
}
}
Expand Down Expand Up @@ -1102,7 +1109,7 @@ export const saveBaseConfigFn = createServerFn({ method: 'POST' })
}
}
if (errors.length > 0) {
const details = errors.map((e) => `${e.fieldPath}: ${e.error}`).join('; ');
const details = errors.map((e) => e.error).join('; ');
throw new Error(`Validation failed — ${details}`);
}

Expand Down