📦 fix: Surface Code API Artifact Truncation - #565
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d83897d4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Review handoff for head |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94db63972b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Review handoff for head |
|
@codex review the latest head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a05906bf5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Review handoff for head The reason-total finding is fixed. The validator now requires safe integer counts, a positive omission total, and reason counts summing to that total. Empty/all-zero reason maps and contradictory totals are discarded. Subsystem invariant review
VerificationNine focused suites passed: 481 tests. Suites: ArtifactTruncation, ArtifactDelivery, CodeApiAuthHeaders, ProgrammaticToolCalling, ProgrammaticPlainExecution, BashExecutor, CodeExecutor.stateful, LocalExecutionTools, CloudflareSandboxExecution. Typecheck ( Not run: live Code API reproduction, full local test suite, or transitive codegraph selection closure. Graph evidence used agents head CI passed all 13 checks on this head. All three reported review threads are resolved. A maintainer-triggered Codex review is still needed for this exact SHA; prior reviews do not cover it. |
|
@codex review the latest head |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Surface Code API artifact truncation for every execution path so agents and hosts can tell when generated files were omitted from delivery (fixes #556).
artifact_truncationresponse with bounded paths and known reasons. Require safe integer counts and reason totals equal to the positive omission count; discard malformed or contradictory markers.execute_code, direct Bash, and both plain and tool-backed Bash/Python programmatic execution.Change Type
Testing
tsc --noEmit, touched-file ESLint, import-order check, andnpm run buildpassed.Checklist