Skip to content

GitHub App bot identity rejects single-digit user IDs #250

Description

@danny-avila

In github.ts, wrapGitHubCredentialCommand validates the no-reply email with [1-9][0-9]+, requiring at least two digits. resolveActor accepts any positive integer user ID and can emit a single-digit ID. For IDs 1–9, hasActor is false and the wrapper omits user.name and user.email, so App-authenticated commits lose the canonical bot identity. Accept [1-9][0-9]* and add a single-digit ID test. Found during downstream sync review: https://github.com/ClickHouse/ai/pull/4009#discussion_r4100803952

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions