Skip to content

Invalid GitHub remotes can abort worker startup #251

Description

@danny-avila

gitHubRepositoryForDirectory is documented to return undefined for unusable remotes and catches git errors, but calls repositoryName(repository) without catching its validation error. projectRemote permits paths with more than owner/name (for example a copied GitHub web URL), so one admitted root with such a remote rejects the startup Promise.all and prevents the worker from starting. Treat an invalid repository path as undefined (or validate before returning) and add a startup regression test. Found during downstream sync review: https://github.com/ClickHouse/ai/pull/4009#discussion_r4100803959

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions