Skip to content

For sCMOS cameras, gain, offset, readnoise should be allowed to be scalars #37

Description

@MJWester

Right now, for the SCMOS CameraType, if CameraGain, CameraOffset and CameraNoise are scalars and CalibrationFilePath is empty, the algorithm can access random bits of memory, Note the comments in DataToPhotons:
% NOTE: This may be overwritten below if a calibration file
% is present and the camera type is specified as
% 'SCMOS'. If that happens, it was done on purpose!
% It's best to use the value in the calibration file
% rather than what the user has entered.

                % If no filepath is given, or if the camera is
                % specified as an EMCCD, we don't need to load a
                % calibration file.

The fix is to make a 2D array for each of these quantities of the appropriate size and set equal to the scalar value provided, probably in DataToPhotons.m

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions