Reduce Warnings

[Lightning11wins]

This PR greatly reduces / nearly eliminates warnings when building centrallix, centrallix-lib, and their associated test suites with default configuration flags. This will reduce the number of bugs that make it to production in the future by making legitimate warnings far more obvious when building the project.

[Lightning11wins]

@greptileai Please review this code anyway.

[greptile-apps]

Greptile Summary

This PR removes or suppresses compiler warnings across 114 files in centrallix and centrallix-lib, with changes ranging from removing genuinely dead variables and unused global structs to adding #pragma GCC diagnostic guards and (char*) casts. One incidental real fix is included: aposSetLimits now propagates the error return from aposSetLimits_r instead of always returning 0.

• Dead code removal (htmlgen, multiquery, netdrivers, osdrivers): Unused idcnt global structs and their derived id locals are deleted from a dozen htdrv_*.c files; unused variables (rval, objlist, is_outer, box_offset, bx/by/bw/bh) are removed from several core files — all safe, no behaviour change.
• Warning suppression via pragmas (mtask.c): #pragma GCC diagnostic push/pop wraps the intentionally uninitialized stack reads that MTASK requires; this is the appropriate mechanism for deliberately unsafe-looking but required code.
• Const-casting in cxss_credentials_mgr.c: const char* parameters passed to cxssShred are cast to char* to silence the discarded-qualifier warning, silencing a signal that the function signatures should not promise const for buffers they will shred.

Confidence Score: 5/5

Safe to merge — the changes are overwhelmingly dead-code removal with no behaviour change, plus one genuine bug fix in aposSetLimits.

The vast majority of changes remove variables that were assigned but never read, or delete unused global counters. The pragma-based suppression in mtask.c is the right tool for intentionally unsafe stack code. The const-casting in cxss_credentials_mgr.c obscures an API design smell but does not introduce new misbehaviour. The aposSetLimits return-value fix is a correct improvement.

centrallix/cxss/cxss_credentials_mgr.c (const-casting) and centrallix/utility/json_util.c (empty else-if branches) are worth a second look for long-term cleanliness, but neither poses a runtime risk.

Important Files Changed

Filename	Overview
centrallix-lib/src/mtask.c	Added #pragma GCC diagnostic push/pop to suppress intentional uninitialized stack reads used for MTASK's stack-allocation trick across three functions.
centrallix/wgtr/apos.c	Removed unused variables; also fixes aposSetLimits to return the actual rval from aposSetLimits_r rather than always returning 0.
centrallix/utility/json_util.c	Commented-out has_hour/minute/second/tz tracking variables replaced with empty else if (cond); no-op branches; functionally identical but leaves confusing dead code.
centrallix/cxss/cxss_credentials_mgr.c	Added (char*) casts throughout to suppress discarded-const warnings when passing caller-provided keys to cxssShred; masks an API const-correctness issue.
centrallix/multiquery/multiq_equijoin.c	Removed is_outer variable which was assigned but never read anywhere in the function.
centrallix/htmlgen/htdrv_window.c	Commented out bx/by/bw/bh geometry block — those variables were computed but never consumed; no functional change.
centrallix/netdrivers/net_http.c	Dropped unused rval variable that stored nht_i_RestGet's return value without ever being checked.
centrallix/htmlgen/htdrv_connector.c	Removed idcnt-based global struct and the id local variable derived from it, which were computed but unused.
centrallix/cxss/cxss_crypto.c	Changed seed buffer from char[256] to unsigned char[256] to match the expected type of cxss_internal_GetBytes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Warning Sources] --> B[Unused variables]
    A --> C[Intentional uninitialized stack reads]
    A --> D[Signed vs unsigned mismatch]
    A --> E[Discarded const qualifier]

    B --> B1[Delete variable and assignment]
    C --> C1[pragma GCC diagnostic push/pop]
    D --> D1[char to unsigned char]
    E --> E1[Cast away const with char-ptr]

    B1 --> F[No behaviour change]
    C1 --> F
    D1 --> F
    E1 --> G[Warning silenced but const API issue remains]

    style G fill:#ffcccc

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Warning Sources] --> B[Unused variables]
    A --> C[Intentional uninitialized stack reads]
    A --> D[Signed vs unsigned mismatch]
    A --> E[Discarded const qualifier]

    B --> B1[Delete variable and assignment]
    C --> C1[pragma GCC diagnostic push/pop]
    D --> D1[char to unsigned char]
    E --> E1[Cast away const with char-ptr]

    B1 --> F[No behaviour change]
    C1 --> F
    D1 --> F
    E1 --> G[Warning silenced but const API issue remains]

    style G fill:#ffcccc

Loading

_{Reviews (2): Last reviewed commit: "Add explicit casts to remove const in we..." | Re-trigger Greptile}

[Lightning11wins]

Wow, sounds great.

This PR is cleared for human review.

[Lightning11wins]

The conversation is getting a little cluttered, so I think I should repost this.

This PR is cleared for human review.

[Lightning11wins]

With those commits, I think I've successfully eliminated all warnings on the latest current master.