Skip to content

Include mssError() when used#98

Merged
gbeeley merged 2 commits into
masterfrom
include-msserror
Jun 16, 2026
Merged

Include mssError() when used#98
gbeeley merged 2 commits into
masterfrom
include-msserror

Conversation

@Lightning11wins

Copy link
Copy Markdown
Contributor

Some files call msError() without including cxlib/mtsession.h. This latent mistake caused compiler errors when I made an otherwise safe change in code I plan to commit to for #77 once it's not being reviewed.

I'm making this a new PR because I don't want to mix even more mostly unrelated changes into the dups branch, and I think these changes will be obviously safe on their own, so they should be trivial to review, approve, and merge.

@Lightning11wins Lightning11wins self-assigned this Apr 24, 2026
@Lightning11wins Lightning11wins added the ai-review Request AI review for PRs. label Apr 24, 2026
@greptile-apps

greptile-apps Bot commented Apr 24, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds the missing #include "cxlib/mtsession.h" header to 10 source files that call mssError() without previously declaring it, fixing latent compiler errors. It also removes trailing blank lines from several files. No logic is changed.

Confidence Score: 5/5

This PR is safe to merge — it makes no logic changes, only adds missing header includes.

All changes are mechanical header additions to files that already use mssError(). No logic, no data flow, and no behavior is altered.

No files require special attention.

Important Files Changed

Filename Overview
centrallix/cxss/cxss_credentials_db.c Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline.
centrallix/cxss/cxss_crypto.c Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline.
centrallix/cxss/cxss_util.c Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline.
centrallix/objectsystem/obj_content.c Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline.
centrallix/objectsystem/obj_session.c Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline.
centrallix/utility/obfuscate.c Added missing #include cxlib/mtsession.h for mssError() usage; removed two trailing newlines.
centrallix/utility/param.c Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline.
centrallix/utility/ptod.c Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline.
centrallix/wgtr/apos.c Added missing #include cxlib/mtsession.h for mssError() usage.
centrallix/wgtr/wgtr.c Added missing #include cxlib/mtsession.h for mssError() usage.

Reviews (3): Last reviewed commit: "Include "cxlib/mtsession.h" everywhere m..." | Re-trigger Greptile

@Lightning11wins

Copy link
Copy Markdown
Contributor Author

Cleared for human review.

@Lightning11wins Lightning11wins added size: trivial Easy to review, probably ~100 lines or fewer. bug and removed bug labels Apr 27, 2026
@Lightning11wins

Copy link
Copy Markdown
Contributor Author

This PR is cleared for human review.

@gbeeley gbeeley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@gbeeley gbeeley merged commit 8b33e4f into master Jun 16, 2026
1 check passed
@Lightning11wins Lightning11wins deleted the include-msserror branch June 16, 2026 20:40
@Lightning11wins Lightning11wins removed the request for review from nboard June 16, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request AI review for PRs. size: trivial Easy to review, probably ~100 lines or fewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants