Add Associations App#61
Open
Lightning11wins wants to merge 97 commits into
Open
Conversation
Add basic UI and editing logic. Add associations app to the Kardia home page.
Refactor fields that might be read only into a component. Implement create blank override button. Add code to query kardia partner names.
Lightning11wins
added
the
size: medium
… bugs to be more visible in the UI).
Lightning11wins
force-pushed
the
add-associations-app3
branch
from
ec0c65c to
1a86776
Compare
Add net amount to the associations table. Add missing internal associations table fields. Improve some error cases.
Add code to propagate edits to i_eg_deposit_gross_amt onto i_eg_gift_amount. Add code to propagate edits to i_eg_deposit_amt onto i_eg_net_amount.
Remove i_eg_line_item from the Line Item Details table. Add a_fund to the line items table.
…ngle designations.
…the osrc. Clean up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add the
associations_app, following the designs I got from Noah.Known Issues
s_date_modifedands_modified_byare not updated. This is likely due to the following suppressed errors in the console, which are caused by the/apps/kardia/modules/base/record_metadata_hidden.cmpcomponent:Known Issues
Due to Centrallix issues
Before Final Review
Before we do our final review of this PR, the following Centrallix PRs should be merged, as they add features used by this app or fix bugs that frequently occur while using it.
ORDER BYs withDEFAULTsORDER BYSeg Fault (again...)It would also be nice to have these PRs merged, but they're not required:
Merging
4f6013833b28b04fb6cec6d4a1bf36f7eb25c26ato the repo ignore refs to improve history forgift_assocations_table.cmp, which had to be renamed in that commit, obscuring its entire change history.