Repository navigation
build: trim musl Canvas binary from glibc server image - #237
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe61654b76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| COPY server/package.json server/package-lock.json server/.npmrc ./ | ||
| COPY package.json /tmp/qualified-package.json | ||
| COPY scripts/prune-pdfjs-server-runtime.mjs /tmp/prune-pdfjs-server-runtime.mjs | ||
| COPY scripts/prune-glibc-canvas-runtime.mjs /tmp/prune-glibc-canvas-runtime.mjs |
There was a problem hiding this comment.
Add this new Docker build input to the server_source or server_docker paths filter. In the inspected .github/workflows/ci.yml, those filters include only two named root scripts and the Dockerfile/ignore files, so a commit that changes only scripts/prune-glibc-canvas-runtime.mjs produces checks: false and publish: false; the pruning logic can therefore change without validation or rebuilding the server image. This also prevents CI from certifying the exact candidate commit as required.
AGENTS.md reference: AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
Remove the unused musl Canvas binary from the Debian/glibc server image while preserving the glibc Canvas binding and formal runtime PDF support. No runtime version, authorization, application behavior or schema changes are introduced.
The original commit
fe61654b76c6cc47f70351ad04f2c4819d9111b8is preserved in integrated PR239 candidate9a5cfda82ad105d666bf0452df1d615daf6c6a28. Independent native/PDF review passed15checks; exact original CI39419779502 and integrated CI39444057773 succeeded. Final OCI audit verified exactly one removed30,315,608-byte file and18unchanged retained Canvas entries. Compressed image size fell13,021,932bytes (6.3226%).PR239 completed production acceptance at2026-10-20T15:45:47.705Z:all4services healthy,36native terminal success receipts,16/16acceptance checks, actual Canvas/PDF probes on bothhosts. Detailed evidence.
#229 remains open for controlled cold/warm build and peak-disk evidence; these were not measured by this change. The fixed3.5.3 soak remains untouched.