touchy: stop MDI, listing and file panes resizing with content#4151
Open
grandixximo wants to merge 3 commits into
Open
touchy: stop MDI, listing and file panes resizing with content#4151grandixximo wants to merge 3 commits into
grandixximo wants to merge 3 commits into
Conversation
window.maximize() is a GTK2 leftover; a GTK3 GtkWindow has no .window attribute, so starting with window_geometry and window_force_max set in ~/.touchy_preferences crashed at startup. Call maximize() on the window itself, as the default-geometry path already does.
The map-time resize to the content's natural size overrode a user-saved window_geometry preference, so the saved size was never honored. Skip the natural-size resize when an explicit geometry is set; the scroller still bounds the window to the work area.
The MDI word labels, the G-code listing and the file chooser names grow with their text, so typing a long number resized the number pad pane and a long G-code line pushed the page/start-point controls out of view. Wrap each of those label columns in a horizontal scroller (with the existing drag-to-pan) so long content scrolls in place and the layout never moves.
Contributor
Author
|
And I guess today is Docker that crapped itself... |
Contributor
Author
|
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1135890 Its been tracked, hopefully will be fixed soon, I'll send a PR to make the CI less flaky when this happens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4131, for the issues @andypugh reported there: the MDI word labels, the G-code listing and the file chooser names grow with their text, so typing a long number resized the number pad pane, and a long G-code line pushed the page/start point controls out of view. This wraps each of those label columns in a horizontal scroller with the existing drag-to-pan, so long content scrolls in place and the layout never moves.
Two small fixes found while testing: a saved window_geometry preference is honored again (the fit-to-monitor resize was overriding it), and starting with window_force_max set no longer crashes on a GTK2 leftover (.window.maximize()).
Tested in sim: before, typing 16 digits shifted the keypad sideways and a long line pushed the right control column off screen; after, the panes stay pixel-identical while typing and the controls stay visible. Tested locally, waiting for Andy's feedback on this one.