Open
Conversation
Denton-L
force-pushed
the
reproducible-build
branch
from
572d766 to
9473392
Compare
Member
|
If I ever knew, I don't recall the full logic of vendoring Things are not active on this project any longer, but I'll see we if can get this merged. |
Contributor
Author
|
Thanks, I appreciate it! |
Denton-L
force-pushed
the
reproducible-build
branch
from
9473392 to
6821036
Compare
help2man was vendored as part of d5d5253 (Fix bugs reported by Dominique, 2000-10-06) because at the time, help2man did not have a --version-option argument and one needed to be patched in. However, as of help2man 1.29, released in July 2003, this option was added. Remove the vendored version of help2man and use the help2man on the system. It's been released for long enough that all users should be using a version of help2man that's less than 22 years old. This helps because distros such as Arch Linux patch the vendored version of help2man in order to make the build reproducible[0]. However, help2man has been updated to support $SOURCE_DATE_EPOCH for a long time now. Add -n to the gzip call so that the timestamp of the files are not saved. While we're at it, add the generated files to the .gitignore. [0]: https://gitlab.archlinux.org/archlinux/packaging/packages/lsb-release/-/blob/e5ce86591a488e1089e1c246a296adc70679588b/lsb_release_make_man_page_reproducible.patch
Denton-L
force-pushed
the
reproducible-build
branch
from
6821036 to
c7d6a40
Compare
Contributor
Author
|
Hi @mwichmann, just following up on this PR. Thanks! |
Member
|
Fell off radar, sorry (radar is broken). Will take a look soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
help2man was vendored as part of d5d5253 (Fix bugs reported by Dominique, 2000-10-06) because at the time, help2man did not have a --version-option argument and one needed to be patched in. However, as of help2man 1.29, released in July 2003, this option was added.
Remove the vendored version of help2man and use the help2man on the system. It's been released for long enough that all users should be using a version of help2man that's less than 22 years old.
This helps because distros such as Arch Linux patch the vendored version of help2man in order to make the build reproducible0. However, help2man has been updated to support $SOURCE_DATE_EPOCH for a long time now.
Add -n to the gzip call so that the timestamp of the files are not saved.
While we're at it, add the generated files to the .gitignore.