Repository navigation
fix: add missing dependencies to console UI - #878
Merged
LinuxSuRen merged 1 commit intoOct 9, 2026
Merged
Conversation
lodash and @element-plus/icons-vue are imported by the source but were never declared in package.json, which breaks a fresh npm install and makes vite dev / build fail to resolve those imports.
|
|
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | ✅ 0 (≤ 20 complexity) |
| Duplication | ✅ 0 (≤ 1 duplication) |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
console/atest-uiimportslodash(insrc/views/types.ts) and@element-plus/icons-vue(in ten views/components) without declaring them inpackage.json. A fresh clone followed bynpm install && npm run dev(orbuild) fails with:This PR declares both dependencies explicitly:
lodash@^4.17.21@element-plus/icons-vue@^2.3.1(matches the element-plus 2.x already in use)package-lock.jsononly gains the two declarations — both packages were already resolved as transitive dependencies, so there is no version churn for any existing package.Test
npm install— ok (1179 packages)npx vite build— ok, 1860 modules transformed,dist/generatednpm run type-checkfails identically onmasterand on this branch (ScriptKind is not definedraised from@vue/language-corewith the pinnedtypescript ~5.0.4+vue-tsc ^3.0.0on Node 24) — pre-existing and out of scope for this PR.fix #415