TileOP: extend per-dimension B.DIM sweep to all four-branch interfaces - #83
Merged
Conversation
Add SS/SD/DS/DD instantiations for the remaining four-branch families missed by the first sweep (49 interfaces): - TPARTADD/MAX/MIN/MUL, TSEL, TFMA, TFILLPAD, TEXTRACT, TINSERT, TEXPANDS, TDEQUANT - TROWEXPAND* / TROWARGMAX/MIN (one-column broadcast sources) - TCOLEXPAND* / TCOLARGMAX/MIN (one-row broadcast sources) - TGATHER / TSCATTER (offset-tile driven dispatch) - Shared TSTORE x4 (Shared produced inline via TMOV_L2S_INSERT; the Shared value never crosses the C++ ABI per the PTO_SHARED_INLINE contract — passing SharedTile as a noinline function argument hits the known setRegClass assertion, reproducible on baseline) Total: 101 four-combination instantiations, zero errors, symmetric form matrix (lb0/lb1 static+dynamic pairs, lb2 all immediate). Still not sweepable (pre-existing blockers, identical on baseline): - TLOAD2/TLOAD4: B.DATR ND2NZ alias missing .normal suffix - TIMG2COL/TMATMUL options path: pre-existing match errors - TLOAD plain form: "i"-constraint bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #82, which was merged before this commit landed on its branch.
The first sweep fixture only covered 48 of the 97 four-branch B.DIM interfaces. This adds the missing 49 (SS/SD/DS/DD each):
Total: 101 four-combination instantiations, zero compile errors, verified against the merged linx head (67d47ab). Disassembly form matrix across the whole fixture:
Symmetric static/dynamic pairs on lb0/lb1; lb2 always immediate; zero illegal forms.
Not sweepable due to pre-existing blockers (identical on baseline): TLOAD2/TLOAD4 (B.DATR ND2NZ alias missing .normal), TIMG2COL/TMATMUL-options match errors, TLOAD plain-form i-constraint bug.