Revert "TileOP: enforce CUBE InternalAcc CCTRL legality (spec#236) (#84)" - #85
Merged
Conversation
…)" This reverts commit 32c4804.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the CUBE InternalAcc CCTRL legality change (#84) from linx.
Reason
Version tag freeze: a release tag is being cut from linx and this feature is not in scope for that version. This is a timing revert, not a quality revert — no defects were identified in #84.
The change should be re-landed after the tag is cut. The branch
codex/cube-internalacc-legality(commitde84656) remains intact for that.What this reverts
validate_cube_ctrl_contractcall sites in matmul/matmul_acc/matmul_bias/matmul_mx/MX-5SRC)with_cube_ctrlfixCubeInternalAccgolden/negative fixturesNot touched (predate #84, from 33cb600): typed
CubeControlenum,Options::raw_acc()/acc_hint(),PTO_MATMUL_HEADERCCTRL encoding, C,A,B operand order.Verification
80cfeacis empty)Note for re-landing
The latent bugs #84 fixed become active again after this revert (inert CCTRL[1] check on non-ACC paths, MX mispositioning on two ACC emitters, attribute-dropping static
with_cube_ctrl). They are documented in #84 and should be re-landed together with the feature after the tag.