Skip to content

Revert "TileOP: enforce CUBE InternalAcc CCTRL legality (spec#236) (#84)" - #85

Merged
VV0003 merged 1 commit into
linxfrom
revert-pr84
Sep 8, 2026
Merged

Revert "TileOP: enforce CUBE InternalAcc CCTRL legality (spec#236) (#84)"#85
VV0003 merged 1 commit into
linxfrom
revert-pr84

Conversation

@VV0003

@VV0003 VV0003 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Reverts the CUBE InternalAcc CCTRL legality change (#84) from linx.

Reason

Version tag freeze: a release tag is being cut from linx and this feature is not in scope for that version. This is a timing revert, not a quality revert — no defects were identified in #84.

The change should be re-landed after the tag is cut. The branch codex/cube-internalacc-legality (commit de84656) remains intact for that.

What this reverts

  • Validator wiring (validate_cube_ctrl_contract call sites in matmul/matmul_acc/matmul_bias/matmul_mx/MX-5SRC)
  • MX/IsAccForm template-argument mispositioning fixes (12 call sites)
  • Chainable with_cube_ctrl fix
  • CubeInternalAcc golden/negative fixtures

Not touched (predate #84, from 33cb600): typed CubeControl enum, Options::raw_acc()/acc_hint(), PTO_MATMUL_HEADER CCTRL encoding, C,A,B operand order.

Verification

Note for re-landing

The latent bugs #84 fixed become active again after this revert (inert CCTRL[1] check on non-ACC paths, MX mispositioning on two ACC emitters, attribute-dropping static with_cube_ctrl). They are documented in #84 and should be re-landed together with the feature after the tag.

@VV0003
VV0003 merged commit 5b41111 into linx Sep 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant