fix(FolderBrowser): commit manually-typed inline path to v-model (#523)#687
Open
pathak-satyam wants to merge 1 commit into
Open
fix(FolderBrowser): commit manually-typed inline path to v-model (#523)#687pathak-satyam wants to merge 1 commit into
pathak-satyam wants to merge 1 commit into
Conversation
…tenarrs#523) The inline path input bound to a local ref and only emitted `path-draft` on manual typing, never `update:modelValue`. Consumers that bind the field with `v-model` (e.g. RemotePathMappingModal) listen only for `update:modelValue`, so typed values were dropped and the save payload sent `localPath: ""`. Emit `update:modelValue` on input, gated on `inline && autoSelect` so modal-embedded browsers (autoSelect=false) keep their draft-only semantics. Guard the `modelValue` watcher against echoes of our own emit to avoid a path-validation request on every keystroke. Add unit tests asserting the typed value is committed when autoSelect is on and stays silent (draft only) when autoSelect is false.
pathak-satyam
force-pushed
the
fix/523-inline-path-mapping
branch
from
8e9121e to
9afde32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #523 — manually typed local path values in the remote path mapping form were not being sent to the backend.
Changes
Fixed
FolderBrowser.vue: inline text input now emitsupdate:modelValueon typing, not justpath-draftmodelValuewatcher to prevent feedback loopAdded
FolderBrowser.inlineInput.spec.ts: two unit tests covering the fixTesting
Notes
Root cause: the inline input was draft-only and never committed its value to v-model. Fix is scoped to
props.inline && props.autoSelectso the browse-modal flow is untouched.