-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
build(windows): add arm64 support #3905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9652b53
fix(build): using minhook-detours for arm64
rbqvq 27bfea2
fix(build): disable Steam Audio Driver for Windows ARM64
rbqvq 3d0ca48
fix(build): clang namespace resolution
rbqvq bdcdc6a
fix(build): clang/llvm icon path error
rbqvq 70b76f9
feat: add Qualcomm Adreno GPU detection
faratech 5ef76c5
feat: add Media Foundation encoder for Windows ARM64
faratech a3a4972
fix(build): using @rollup/wasm-node
rbqvq 538bc60
chores(build): disable warnings for Windows ARM64
ReenigneArcher d694527
chores: use std::vector instead of VLAs on Windows
ReenigneArcher 991ab16
fix(build): drop unused HMODULE member from nvenc header
ReenigneArcher 8227eb7
ci(build/windows): add support for arm64
rbqvq 0ae6e4e
docs(windows): add documents for arm64
rbqvq 940bb3e
docs(building): update syntax for github admonition
ReenigneArcher da1705d
Add NSIS debug step to Windows CI
ReenigneArcher d786505
Enable NSIS logging only on AMD64
ReenigneArcher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,35 @@ | ||
| # windows specific dependencies | ||
|
|
||
| # Make sure MinHook is installed | ||
| find_library(MINHOOK_LIBRARY libMinHook.a REQUIRED) | ||
| find_path(MINHOOK_INCLUDE_DIR MinHook.h PATH_SUFFIXES include REQUIRED) | ||
| # MinHook setup - use installed minhook for AMD64, otherwise download minhook-detours for ARM64 | ||
| if(CMAKE_SYSTEM_PROCESSOR MATCHES "AMD64") | ||
| # Make sure MinHook is installed for x86/x64 | ||
| find_library(MINHOOK_LIBRARY libMinHook.a REQUIRED) | ||
| find_path(MINHOOK_INCLUDE_DIR MinHook.h PATH_SUFFIXES include REQUIRED) | ||
|
|
||
| add_library(minhook::minhook STATIC IMPORTED) | ||
| set_property(TARGET minhook::minhook PROPERTY IMPORTED_LOCATION ${MINHOOK_LIBRARY}) | ||
| target_include_directories(minhook::minhook INTERFACE ${MINHOOK_INCLUDE_DIR}) | ||
| add_library(minhook::minhook STATIC IMPORTED) | ||
| set_property(TARGET minhook::minhook PROPERTY IMPORTED_LOCATION ${MINHOOK_LIBRARY}) | ||
| target_include_directories(minhook::minhook INTERFACE ${MINHOOK_INCLUDE_DIR}) | ||
| else() | ||
| # Download pre-built minhook-detours for ARM64 | ||
| message(STATUS "Downloading minhook-detours pre-built binaries for ARM64") | ||
| include(FetchContent) | ||
|
|
||
| FetchContent_Declare( | ||
| minhook-detours | ||
| URL https://github.com/m417z/minhook-detours/releases/download/v1.0.6/minhook-detours-1.0.6.zip | ||
| URL_HASH SHA256=E719959D824511E27395A82AEDA994CAAD53A67EE5894BA5FC2F4BF1FA41E38E | ||
| ) | ||
| FetchContent_MakeAvailable(minhook-detours) | ||
|
|
||
| # Create imported library for the pre-built DLL | ||
| set(_MINHOOK_DLL | ||
| "${minhook-detours_SOURCE_DIR}/Release/minhook-detours.ARM64.Release.dll" | ||
| CACHE INTERNAL "Path to minhook-detours DLL") | ||
| add_library(minhook::minhook SHARED IMPORTED GLOBAL) | ||
| set_property(TARGET minhook::minhook PROPERTY IMPORTED_LOCATION "${_MINHOOK_DLL}") | ||
| set_property(TARGET minhook::minhook PROPERTY IMPORTED_IMPLIB | ||
| "${minhook-detours_SOURCE_DIR}/Release/minhook-detours.ARM64.Release.lib") | ||
| set_target_properties(minhook::minhook PROPERTIES | ||
| INTERFACE_INCLUDE_DIRECTORIES "${minhook-detours_SOURCE_DIR}/src" | ||
| ) | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.