feat(installer/windows): add wix installer#3916
Conversation
14ce5ed to
f20af0e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3916 +/- ##
=========================================
Coverage ? 11.20%
=========================================
Files ? 69
Lines ? 12248
Branches ? 5927
=========================================
Hits ? 1372
Misses ? 10394
Partials ? 482
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bundle ReportBundle size has no change ✅ |
9e4b955 to
6ef5e6e
Compare
|
|
The latest NSIS version now runs properly on ARM64 systems, so we can stick with NSIS if we want. WiX does make it easier to support having a single unified installer for both x64 and ARM64 binaries if we want that. |
|
Good to know. I still need to setup a VM to test this out. I think msi would still be nice to use, especially for anyone installing Sunshine with a script as it supports more CLI options. I discovered in a recent change that I couldn't even get the output of the installer scripts to a log file with NSIS. Do you know the process for unifying the installer? That would be pretty nice. |
c3efb02 to
07c0044
Compare
07c0044 to
805e270
Compare
a348849 to
a6dbf17
Compare
a6dbf17 to
e18cc13
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
e18cc13 to
e117752
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
59eaea1 to
953c971
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
f7098da to
9de1a60
Compare
|
Simplified installer by adding a new powershell script in #4675 and refactored this PR to use it. powershell window is hidden when using quiet install/uninstall and shown otherwise. The script has decent feedback so I don't think it's an issue to show it, but we can easily hide it if we want. The output is also sent to a log file to help with debugging installation issues. Start menu is also fixed, but I think there's a bug with Windows 11 that requires restarting explorer in order to see it updated after an uninstall. I noticed files remained in the start menu gui after an uninstall from both the nsis and wix installer, but they are removed from "C:\ProgramData\Microsoft\Windows\Start Menu\Programs" immediately. |
9de1a60 to
e847cc8
Compare
e847cc8 to
0db792c
Compare
|



Description
This PR adds a WIX installer for Sunshine. The NSIS installer will be removed at a later point after any bugs with the WIX installer are ironed out.
This is a requirement for having an ARM64 installer for #3905 or #3369
TODO:
For first release after this is merged, we will keep both exe and msi, so that the winget automation will still work to auto update winget. We will then to update winget manually to use the msi
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist