chore(packaging/copr): Use standard cmake macros by LecrisUT · Pull Request #5341 · LizardByte/Sunshine

LecrisUT · 2026-06-26T11:59:04Z

Description

This will pick up the distro's best generator, e.g. since Fedora 44 it uses Ninja.

For now I am starting with a small PR because I am not sure what flow you would prefer for these kind of cleanups. One PR at a time or grouped together with documented individual commits?

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

Checklist

Code follows the style guidelines of this project
Code has been self-reviewed
Code has been commented, particularly in hard-to-understand areas
Code docstring/documentation-blocks for new or existing methods/components have been added or updated
Unit tests have been added or updated for any new or modified functionality

AI Usage

None: No AI tools were used in creating this PR
Light: AI provided minor assistance (formatting, simple suggestions)
Moderate: AI helped with code generation or debugging specific parts
Heavy: AI generated most or all of the code changes

codecov · 2026-06-26T15:22:02Z

Bundle Report

Bundle size has no change ✅

codecov · 2026-06-26T16:30:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@3437a0b). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #5341   +/-   ##
=========================================
  Coverage          ?   27.45%           
=========================================
  Files             ?      113           
  Lines             ?    25554           
  Branches          ?    11244           
=========================================
  Hits              ?     7016           
  Misses            ?    15473           
  Partials          ?     3065

Flag	Coverage Δ
Archlinux	`0.00% <ø> (?)`
FreeBSD-amd64	`13.24% <ø> (?)`
Homebrew-macos-14	`21.00% <ø> (?)`
Homebrew-macos-15	`21.17% <ø> (?)`
Homebrew-macos-26	`21.31% <ø> (?)`
Homebrew-ubuntu-24.04	`13.00% <ø> (?)`
Linux-AppImage	`12.34% <ø> (?)`
Windows-AMD64	`15.26% <ø> (?)`
Windows-ARM64	`13.30% <ø> (?)`
macOS-arm64	`19.27% <ø> (?)`
macOS-x86_64	`18.76% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3437a0b...073854d. Read the comment docs.

ReenigneArcher · 2026-06-26T17:17:26Z

copr builds failed:

+ /usr/bin/cmake --install redhat-linux-build
CMake Error: Not a file: /builddir/build/BUILD/Sunshine-0.0.5341-build/redhat-linux-build/cmake_install.cmake
CMake Error: Error processing file: /builddir/build/BUILD/Sunshine-0.0.5341-build/redhat-linux-build/cmake_install.cmake
error: Bad exit status from /var/tmp/rpm-tmp.VdUp8U (%install)

LecrisUT · 2026-06-26T17:23:58Z

copr builds failed:

+ /usr/bin/cmake --install redhat-linux-build
CMake Error: Not a file: /builddir/build/BUILD/Sunshine-0.0.5341-build/redhat-linux-build/cmake_install.cmake
CMake Error: Error processing file: /builddir/build/BUILD/Sunshine-0.0.5341-build/redhat-linux-build/cmake_install.cmake
error: Bad exit status from /var/tmp/rpm-tmp.VdUp8U (%install)

Probably some inconsistent cd paths or such. I will look into it

ReenigneArcher · 2026-06-30T16:40:29Z

Now only opensuse is failing.

https://copr.fedorainfracloud.org/coprs/build/10664281/

LecrisUT · 2026-06-30T21:42:16Z

Now only opensuse is failing.

https://copr.fedorainfracloud.org/coprs/build/10664281/

Yeah, seems like the macro details diverge for these 2 distros¹. The interface are the same, so if we can use ctest ² the difference once again vanish.

suse and fedora ↩
Deferred to https://github.com/LizardByte/Sunshine/pull/5361 ↩

ReenigneArcher · 2026-06-30T21:49:33Z

You can just put the changes from your other PR into this one

This will pick up the distro's best generator

sonarqubecloud · 2026-07-01T00:31:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ReenigneArcher · 2026-07-01T01:06:52Z


 # tests
 if(BUILD_TESTS)
+    enable_testing()


This is already in the tests/CMakeLists.txt... is it truly necessary here?

Yes, the location affects where you can run ctest from. Before you had to do it from {builddir}/tests, but with this you can do it from {builddir}

LecrisUT · 2026-07-01T06:30:19Z

  "-DSUNSHINE_PUBLISHER_NAME=LizardByte"
  "-DSUNSHINE_PUBLISHER_WEBSITE=https://app.lizardbyte.dev"
  "-DSUNSHINE_PUBLISHER_ISSUE_URL=https://app.lizardbyte.dev/support"
+  "-DCMAKE_TEST_LAUNCHER=xvfb-run"


Was assuming there is CMake 3.29 at least everywhere, but it's not the case for opensuse leap 15.x. Leap 16 has CMake 3.31. I will check with copr team why those are not made available since opensuse 15.6 is already EOL. But also just to confirm, which opensuse version would you like to build on?

fedora-copr/copr#4372

But also just to confirm, which opensuse version would you like to build on?

Ideally whichever one is supported... but it's becoming apparent that OpenSuse is a second class citizen on copr. (#5353 (comment))

Fwiw, we did do some work to support OBS with packit, but that kinda stalled because of lack of push from users. If interested to build there, we can probably revive the effort.

But for now, I am considering just waiting it out 1 week to see if the new chroot will be added.

Just to add some context regarding openSUSE: there is already an open PR by me adding Tumbleweed support, but it currently can't be merged because of an existing bug with Tumbleweed in Copr. Any changes made to accommodate Leap's older CMake version could definitely impact or break that Tumbleweed build.

Regarding OBS: that's unfortunately a no-go for the full version. Because of NVENC licensing restrictions, OBS can't build it with NVENC enabled (there is actually already an NVENC-less build sitting in games:tools on OBS right now).

Sticking with Copr is the best bet to get a fully-featured build on openSUSE, so it really does seem like waiting for Copr to sort out the chroots/bugs for both Leap and Tumbleweed is the only way forward.

ReenigneArcher requested changes Jun 26, 2026

View reviewed changes

Comment thread packaging/linux/copr/Sunshine.spec

ReenigneArcher force-pushed the chore/spec-cleanup/cmake branch from 8764719 to 4710e19 Compare June 26, 2026 15:16

ReenigneArcher previously approved these changes Jun 26, 2026

View reviewed changes

ReenigneArcher changed the title ~~chore(spec): Use standard cmake macros~~ chore(copr): Use standard cmake macros Jun 26, 2026

ReenigneArcher changed the title ~~chore(copr): Use standard cmake macros~~ chore(packaging/copr): Use standard cmake macros Jun 26, 2026

LecrisUT dismissed ReenigneArcher’s stale review via bf2d380 June 30, 2026 09:42

LecrisUT force-pushed the chore/spec-cleanup/cmake branch 2 times, most recently from bf2d380 to 44be8f3 Compare June 30, 2026 09:50

ReenigneArcher force-pushed the chore/spec-cleanup/cmake branch from 44be8f3 to 31781bc Compare June 30, 2026 13:59

LecrisUT force-pushed the chore/spec-cleanup/cmake branch from 31781bc to fa2abc1 Compare June 30, 2026 21:23

LecrisUT mentioned this pull request Jun 30, 2026

chore(cmake): Define the google tests as a ctest #5361

Closed

21 tasks

LecrisUT added 5 commits June 30, 2026 20:26

Use standard cmake macros

64b8f91

This will pick up the distro's best generator

Account for different build dir definition on opensuse

5c83eab

Allow ctest to be launched from main builddir

5abdf71

Add tests as ctest

b9628c9

Use ctest in spec file

073854d

ReenigneArcher force-pushed the chore/spec-cleanup/cmake branch from 4be7530 to 073854d Compare July 1, 2026 00:26

ReenigneArcher reviewed Jul 1, 2026

View reviewed changes

LecrisUT commented Jul 1, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

LecrisUT commented Jun 26, 2026

Description

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

Checklist

AI Usage

Uh oh!

Uh oh!

codecov Bot commented Jun 26, 2026

Bundle Report

Uh oh!

codecov Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ReenigneArcher commented Jun 26, 2026

Uh oh!

LecrisUT commented Jun 26, 2026

Uh oh!

ReenigneArcher commented Jun 30, 2026

Uh oh!

LecrisUT commented Jun 30, 2026

Footnotes

Uh oh!

ReenigneArcher commented Jun 30, 2026

Uh oh!

sonarqubecloud Bot commented Jul 1, 2026

Quality Gate passed

Uh oh!

ReenigneArcher Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

LecrisUT Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

LecrisUT Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

LecrisUT Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

ReenigneArcher Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

LecrisUT Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

gummiangler Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jun 26, 2026 •

edited

Loading

gummiangler Jul 1, 2026 •

edited

Loading