Skip to content

chore(deps): bump libvirtualhid - #5739

Draft
ReenigneArcher wants to merge 2 commits into
masterfrom
chore/bump-libvirtualhid
Draft

ReenigneArcher wants to merge 2 commits into
masterfrom
chore/bump-libvirtualhid

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Description

Bumps libvirtualhid, fixing support for multi monitor setups on macOS and adds logging callback.

TODO:

  • release libvirtualhid, update submodule commit

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher force-pushed the chore/bump-libvirtualhid branch from 1f74103 to d04baac Compare September 16, 2026 22:06
@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.10526% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.90%. Comparing base (0e87c42) to head (123df48).
⚠️ Report is 27 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/macos/display.mm 80.64% 6 Missing ⚠️
src/input.cpp 92.30% 3 Missing ⚠️
src/video.cpp 0.00% 2 Missing ⚠️
src/platform/virtualhid_input.cpp 98.68% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5739      +/-   ##
==========================================
+ Coverage   38.70%   38.90%   +0.19%     
==========================================
  Files         113      111       -2     
  Lines       26696    26205     -491     
  Branches    11744    11518     -226     
==========================================
- Hits        10334    10194     -140     
+ Misses      14171    13218     -953     
- Partials     2191     2793     +602     
Flag Coverage Δ
Alpine-aarch64 23.66% <72.91%> (+0.35%) ⬆️
Alpine-x86_64 ?
Archlinux ?
FreeBSD-amd64 24.43% <79.43%> (+0.41%) ⬆️
Homebrew-macos-15 38.29% <81.02%> (+0.54%) ⬆️
Homebrew-macos-26 38.61% <81.02%> (+0.54%) ⬆️
Homebrew-ubuntu-24.04 25.62% <76.04%> (+0.30%) ⬆️
Linux-AppImage-aarch64 26.87% <72.91%> (+0.27%) ⬆️
Linux-AppImage-x86_64 27.07% <76.04%> (+0.26%) ⬆️
PowerShell 100.00% <ø> (ø)
Web-UI 85.00% <ø> (ø)
Windows-AMD64 31.06% <79.03%> (+0.23%) ⬆️
Windows-ARM64 ?
macOS-arm64 ?
macOS-x86_64 32.47% <73.68%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/input.h 100.00% <ø> (+50.00%) ⬆️
src/platform/common.h 62.04% <100.00%> (+0.84%) ⬆️
src/platform/virtualhid_input.cpp 97.61% <98.68%> (+0.07%) ⬆️
src/video.cpp 55.06% <0.00%> (+0.43%) ⬆️
src/input.cpp 50.24% <92.30%> (+2.38%) ⬆️
src/platform/macos/display.mm 62.75% <80.64%> (+2.87%) ⬆️

... and 55 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e87c42...123df48. Read the comment docs.

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Last Updated 2026-09-21 15:48:18 UTC
Source Run CI Run #5698
Commit 123df481e4d1775a706c6b908143bec2fc950f4f

Screenshot Comparison

PR #5739 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Consume pending touch-port geometry before forwarding relative mouse motion so libvirtualhid receives the streamed viewport selected by display switching.

Reuse the same desktop conversion for absolute and relative input, avoid recreating the mouse when bounds are unchanged, and preserve the no-device path used on unsupported platforms. Add input-pipeline and virtual HID regression coverage.
@ReenigneArcher
ReenigneArcher force-pushed the chore/bump-libvirtualhid branch from 1db41cd to 123df48 Compare September 21, 2026 14:48
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS mouse on wrong monitor

1 participant