Skip to content

fix(Windows): use overlapped IO for backend IOCTLs - #75

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/windows/latency
Aug 15, 2026
Merged

fix(Windows): use overlapped IO for backend IOCTLs#75
ReenigneArcher merged 1 commit into
masterfrom
fix/windows/latency

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Switch Windows backend DeviceIoControl command paths to a shared per-thread OVERLAPPED event flow, correctly handling immediate completion, ERROR_IO_PENDING, and completion failures on async handles. Add fixture/unit coverage for event usage and pending waits, and update UMDF packaging/docs to run in a dedicated high-priority host process and document the overlapped command behavior.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.96610% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.85%. Comparing base (0c9624b) to head (117301c).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/windows/windows_backend.cpp 77.96% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   74.71%   74.85%   +0.13%     
==========================================
  Files          33       33              
  Lines        7906     7957      +51     
  Branches     2966     2982      +16     
==========================================
+ Hits         5907     5956      +49     
+ Misses       1724     1663      -61     
- Partials      275      338      +63     
Flag Coverage Δ
FreeBSD 50.96% <ø> (ø)
Linux-Clang 56.64% <ø> (-0.02%) ⬇️
Linux-GCC 67.52% <ø> (ø)
Windows-MSVC 88.06% <80.39%> (+0.16%) ⬆️
Windows-MinGW-UCRT64 64.35% <65.21%> (+0.07%) ⬆️
macOS 50.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/windows_backend.cpp 84.67% <77.96%> (+0.61%) ⬆️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9624b...117301c. Read the comment docs.

Switch Windows backend DeviceIoControl command paths to a shared per-thread OVERLAPPED event flow, correctly handling immediate completion, ERROR_IO_PENDING, and completion failures on async handles. Add fixture/unit coverage for event usage and pending waits, and update UMDF packaging/docs to run in a dedicated high-priority host process and document the overlapped command behavior.
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit f957126 into master Aug 15, 2026
32 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/windows/latency branch August 15, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant