Skip to content

test: add SDL3 HIDAPI rumble Windows consumer test - #86

Merged
ReenigneArcher merged 1 commit into
masterfrom
test/rumble
Aug 16, 2026
Merged

test: add SDL3 HIDAPI rumble Windows consumer test#86
ReenigneArcher merged 1 commit into
masterfrom
test/rumble

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Adds an optional Windows integration test that opens virtual DualShock 4, DualSense, and Switch Pro devices through SDL3 HIDAPI and verifies rumble output reaches normalized GamepadOutput callbacks. The test build now links SDL3 (static or shared target) when available and sets a compile definition to gate SDL-dependent code. Also trims the rumble TODO entry to point ongoing Steam/Chromium validation work to GitHub issue #80.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Adds an optional Windows integration test that opens virtual DualShock 4, DualSense, and Switch Pro devices through SDL3 HIDAPI and verifies rumble output reaches normalized GamepadOutput callbacks. The test build now links SDL3 (static or shared target) when available and sets a compile definition to gate SDL-dependent code. Also trims the rumble TODO entry to point ongoing Steam/Chromium validation work to GitHub issue #80.
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.10%. Comparing base (7902b76) to head (37ad99b).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   75.05%   75.10%   +0.04%     
==========================================
  Files          34       34              
  Lines        8083     8083              
  Branches     3029     3029              
==========================================
+ Hits         6067     6071       +4     
- Misses       1430     1435       +5     
+ Partials      586      577       -9     
Flag Coverage Δ
FreeBSD 51.65% <ø> (-0.05%) ⬇️
Linux-Clang 57.23% <ø> (-0.02%) ⬇️
Linux-GCC 67.93% <ø> (ø)
Windows-MSVC 88.19% <ø> (+0.11%) ⬆️
Windows-MinGW-UCRT64 64.90% <ø> (+0.11%) ⬆️
macOS 51.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7902b76...37ad99b. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit b6f192e into master Aug 16, 2026
32 checks passed
@ReenigneArcher
ReenigneArcher deleted the test/rumble branch August 16, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant