Skip to content

fix(license)!: remove expiration-based license validation - #88

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/subscription-expiration
Aug 17, 2026
Merged

fix(license)!: remove expiration-based license validation#88
ReenigneArcher merged 1 commit into
masterfrom
fix/subscription-expiration

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Validate annual subscriptions using recent Polar entitlement checks, normalize pasted license keys, and keep activation available despite stale broker status.

BREAKING CHANGE: Remove expires_at from the public license status and broker protocol.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Validate annual subscriptions using recent Polar entitlement checks, normalize pasted license keys, and keep activation available despite stale broker status.

BREAKING CHANGE: Remove expires_at from the public license status and broker protocol.
@ReenigneArcher
ReenigneArcher force-pushed the fix/subscription-expiration branch from c82a4fb to 119fe00 Compare August 17, 2026 15:24
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.31%. Comparing base (6b06ea9) to head (119fe00).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tools/virtualhid_control.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   75.24%   75.31%   +0.07%     
==========================================
  Files          34       34              
  Lines        8086     8091       +5     
  Branches     3029     3030       +1     
==========================================
+ Hits         6084     6094      +10     
+ Misses       1722     1417     -305     
- Partials      280      580     +300     
Flag Coverage Δ
FreeBSD 51.63% <ø> (ø)
Linux-Clang 57.41% <83.33%> (+0.06%) ⬆️
Linux-GCC 68.09% <83.33%> (+0.05%) ⬆️
Windows-MSVC 88.37% <100.00%> (+0.06%) ⬆️
Windows-MinGW-UCRT64 64.94% <45.45%> (+0.06%) ⬆️
macOS 51.12% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/include/libvirtualhid/license.hpp 100.00% <ø> (ø)
src/platform/windows/windows_license.cpp 0.00% <ø> (ø)
tools/virtualhid_control_model.cpp 98.08% <100.00%> (+0.07%) ⬆️
tools/virtualhid_control.cpp 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b06ea9...119fe00. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit 0cab073 into master Aug 17, 2026
39 of 46 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/subscription-expiration branch August 17, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant