fix: DualShock4 and DualSense improvements

[ReenigneArcher]

Description

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[codecov]

Codecov Report

❌ Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.32%. Comparing base (d98966e) to head (1137f89).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/platform/windows/control_protocol.hpp	90.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   75.23%   75.32%   +0.09%     
==========================================
  Files          34       34              
  Lines        8091     8131      +40     
  Branches     3030     3044      +14     
==========================================
+ Hits         6087     6125      +38     
- Misses       1467     1711     +244     
+ Partials      537      295     -242     

Flag	Coverage Δ
FreeBSD	51.72% <50.00%> (+0.09%)	⬆️
Linux-Clang	57.48% <58.69%> (+0.07%)	⬆️
Linux-GCC	68.19% <91.22%> (+0.09%)	⬆️
Windows-MSVC	88.28% <97.67%> (+0.06%)	⬆️
Windows-MinGW-UCRT64	65.17% <91.11%> (+0.23%)	⬆️
macOS	51.24% <58.33%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/core/profiles.cpp	94.87% <100.00%> (ø)
src/core/report.cpp	93.12% <100.00%> (+0.11%)	⬆️
src/include/libvirtualhid/runtime.hpp	100.00% <ø> (ø)
src/platform/linux/uhid_backend.cpp	81.28% <100.00%> (+0.01%)	⬆️
src/platform/windows/windows_backend.cpp	84.13% <100.00%> (+0.06%)	⬆️
src/platform/windows/control_protocol.hpp	98.70% <90.47%> (-1.30%)	⬇️

... and 8 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98966e...1137f89. Read the comment docs.

[Kishi85]

As a small note: you might want to use Bluetooth as the default profile type for DualShock4 as well as it's using the same playstation kernel driver and therefore is likely to have similar issues to DualSense. Not sure about the Gyro stuff but the same note might apply for that.

EDIT: Did a quick test with ba53378 applied. Result is looking a lot better for the gyro but there's still noise spikes that cause the calibration to fail before it can finish. I know it's still a draft and you're working on it but I wanted to let you know that you're already getting a lot closer to solving this.

[ReenigneArcher]

@Kishi85 thanks! I was going to ping you after I had time to test this, but you can probably test everything on the Linux side faster than me.

I added some adjustments for DS4 as well a tweak that may fix the gyro spikes.

I probably should have tested this better in the first place, but I guess I overlooked the gyro stuff (as I normally prefer the Xbox pads). I'm assuming Moonlight Android doesn't support the gyro and probably just QT does? If so I'll need to find a better way to test this.

[Kishi85]

@Kishi85 thanks! I was going to ping you after I had time to test this, but you can probably test everything on the Linux side faster than me.

I added some adjustments for DS4 as well a tweak that may fix the gyro spikes.

I probably should have tested this better in the first place, but I guess I overlooked the gyro stuff (as I normally prefer the Xbox pads). I'm assuming Moonlight Android doesn't support the gyro and probably just QT does? If so I'll need to find a better way to test this.

I'll test the latest commit first thing tomorrow and give you feedback.

Moonlight-Android does support the gyro but IIRC there's a config option that needs to be enabled for gyro data to be sent to Sunshine.

[ReenigneArcher]

I must be blind because I don't see any such option with the DualSense connected to the Nvidia Shield. I see something about it in the code though. https://github.com/moonlight-stream/moonlight-android/blob/f10085f552b367cf7203007693d91c322a0a2936/app/src/main/java/com/limelight/preferences/StreamSettings.java#L304

Edit: Gyro is still noisy, looking into it more.

Edit 2: Confirmed calibration works in CachyOS host using Moonlight QT in LizardByte/Sunshine#5531

Also discovered that rumble starts working only after opening the calibration in steam, even if rumble is already on before opening the calibration. That's probably a steam bug I guess.

Edit 3: DS4 seems to be working just as well (now). This needed some additional tweaks though in 0c38b9f

[Kishi85]

I must be blind because I don't see any such option with the DualSense connected to the Nvidia Shield. I see something about it in the code though. https://github.com/moonlight-stream/moonlight-android/blob/f10085f552b367cf7203007693d91c322a0a2936/app/src/main/java/com/limelight/preferences/StreamSettings.java#L304

Might require a newer Android base version that the Shield does not have? Like Android 14 is required for rumble with Bluetooth controllers? Not sure which Android version the Shield currently ships.

On my phone (Pixel with Android 17) those options show up:

On my Chromecast wiith GoogleTV (Android 14) I've only got the first option available but that's to be expected as that device does not have a gyro built-in.

Edit: Gyro is still noisy, looking into it more.

Edit 2: Confirmed calibration works in CachyOS host using Moonlight QT in LizardByte/Sunshine#5531

Also discovered that rumble starts working only after opening the calibration in steam, even if rumble is already on before opening the calibration. That's probably a steam bug I guess.

Edit 3: DS4 seems to be working just as well (now). This needed some additional tweaks though in 0c38b9f

Gyro is now working fine for me as well with this PR and LizardByte/Sunshine#5531 applied.

Not sure about rumble not working instantly for you but on my end it is picked up and working upon connecting.

Another additional tool that could be very useful for further development and testing (without having to open Steam's controller settings which could fix things that are otherwise broken, like rumble seems to be on your machine): https://store.steampowered.com/app/2104320/ToS_Gamepad_Tester/
Base version is free and integrates into Steam like any other game (runs via Proton on Linux). Allows testing with SteamInput enabled or disabled (using native Controller integration). Testing advanced features (adaptive triggers, rumble) requires a DLC but it's dirt cheap.

[ReenigneArcher]

Good to know about the Android version requirement, that will make it a little easier to test everything out for me. Hopefully newer Android supports the full range of DualSense features. On the shield I think all of the following didn't work properly:

• LED
• Touchpad
• Rumble
• Gyro
• Battery

And good to know about the gamepad tester.

I'd like to do one more test on this PR with Sunshine on Windows to see if things improve there as well. If all good, then I'll merge it.

Edit: Tested on Windows as well, but using Moonlight Android as a client. Gyro seems to be working fine, but the following are still not working (LED and battery). Touchpad just controls the host mouse even if the setting is off in moonlight settings. Will test from Moonlight-QT to see if these are client issues.

Edit 2: From Moonlight-QT touchpad works as expected. LED and battery still not working. Probably just due to these appearing as USB instead of Bluetooth on the Sunshine host in Windows. And another possible bug on Windows is that Steam reports the gamepad needs a firmware update (same from Android or Moonlight-QT clients). Looking into this closer.

[Kishi85]

From my experience anything above or equal to Android 14 has DualSense fully support over Bluetooth. USB might have it a few Versions earlier but I'm unable to verify due to lack of a matching device.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ReenigneArcher]

100% working on Windows Sunshine host now as well.

@Kishi85 if you could double check on Linux that would be great, otherwise I will test it again tonight. And should we disable "randomize mac" by default? I don't think re-doing the gamepad setup on each connection is the most user friendly thing.