Skip to content

fix(macos): correct right and middle mouse drag handling - #95

Open
mkrusen wants to merge 1 commit into
LizardByte:masterfrom
mkrusen:fix-macos-right-mouse-drag
Open

fix(macos): correct right and middle mouse drag handling#95
mkrusen wants to merge 1 commit into
LizardByte:masterfrom
mkrusen:fix-macos-right-mouse-drag

Conversation

@mkrusen

@mkrusen mkrusen commented Aug 19, 2026

Copy link
Copy Markdown

Description

Fixes macOS right and middle mouse drag handling in the CoreGraphics mouse backend.

I encountered an issue while using Sunshine as a macOS host with Moonlight as the client where a normal right-click worked, but holding the right mouse button while moving the mouse did not behave correctly.

The macOS backend tracks mouse button state with index 0 as left, 1 as right, and 2 as middle. However, event_type_for_current_buttons() mapped the right button to kCGEventOtherMouseDragged and the middle button to kCGEventRightMouseDragged.

This change corrects those mappings so that:

  • the right mouse button generates kCGEventRightMouseDragged
  • the middle mouse button generates kCGEventOtherMouseDragged

It also adds selection of the currently held mouse button for relative and absolute mouse movement. Previously these movement events always passed kCGMouseButtonLeft to post_mouse(), even when the right or middle button was being held.

I tested the change using Sunshine on macOS with Moonlight as the client. Before the change, right-click worked but right-click-and-hold with mouse movement did not work correctly.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@CLAassistant

CLAassistant commented Aug 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher

Copy link
Copy Markdown
Member

@mkrusen thank you for the PR! Could you please review and sign the CLA? #95 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants