Skip to content

Conversation

@Big-Lolo
Copy link
Member

This pull request introduces significant improvements to the project's configuration management, development workflow, and deployment processes. The main highlights are the migration from YAML-based configuration to environment variables, the adoption of new tools for code quality and formatting, and a modernization of deployment and Dockerization strategies.

Configuration and Environment Management:

  • Migrated all configuration from YAML files to environment variables, deprecating the old system. Added .env.example as a template and documented the process in README-config.md. [1] [2]
  • Introduced a new .env file for the main backend environment, and updated code to use Settings for configuration access instead of the old Configuration class. [1] [2] [3]

Development Workflow Enhancements:

  • Added .pre-commit-config.yaml to enforce code formatting and linting with ruff via uv, replacing previous tools.
  • Introduced a new GitHub Actions workflow .github/workflows/code-quality.yml for automated linting and formatting, and removed obsolete workflows for formatting and pylint. [1] [2] [3]
  • Set Python version to 3.12 in .python-version for consistency across tooling.

Deployment and Dockerization:

  • Replaced the old deployment workflow with a more robust .github/workflows/deploy.yml, improving error handling, dependency management (switching to uv), and logging. The previous deployment workflow .github/workflows/deployVPS.yml was removed. [1] [2]
  • Updated the Dockerfile to use the uv Python 3.12 image, install dependencies with uv, and improve build and run commands.

Codebase Modernization:

  • Refactored code and migration scripts to use consistent formatting and updated configuration import paths (Settings instead of Configuration). [1] [2] [3] [4] [5]
  • Improved code style and readability in App.py and migration scripts. [1] [2] [3] [4]

These changes collectively modernize the project, making configuration more secure and manageable, streamlining development and deployment workflows, and ensuring a more maintainable codebase.

Big-Lolo and others added 30 commits November 4, 2024 00:57
- Generate Python client from mail-backend OpenAPI spec
- Fix ModuleNotFoundError for generated_src.lleida_hack_mail_api_client.api
- Simplify Dockerfiles and add alembic migrations on startup
- Add required __init__.py files for Python package structure

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Switch from poetry to uv for dependency management
- Add comprehensive Settings configuration management
- Simplify Dockerfile with uv image and alembic migrations
- Update authentication and JWT handling
- Add environment configuration examples
- Remove deprecated Configuration.py in favor of Settings.py
- Update mail client and event router implementations

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@classmethod
def password_validation(cls, v):
if (re.search("^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\w\W]{8,}$", v)
if (re.search(r"^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\w\W]{8,}$", v)

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium

Suspicious character range that overlaps with \w in the same character class.
@classmethod
def password_validation(cls, v):
if (re.search("^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\w\W]{8,}$", v)
if (re.search(r"^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\w\W]{8,}$", v)

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium

Suspicious character range that overlaps with \w in the same character class.
@Big-Lolo Big-Lolo merged commit 42fdf94 into main Sep 25, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants