-
Notifications
You must be signed in to change notification settings - Fork 2
Integration #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Integration #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tonlls patch 1
Poetry migrated to UV
Modernization end
improving token
- Generate Python client from mail-backend OpenAPI spec - Fix ModuleNotFoundError for generated_src.lleida_hack_mail_api_client.api - Simplify Dockerfiles and add alembic migrations on startup - Add required __init__.py files for Python package structure 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Switch from poetry to uv for dependency management - Add comprehensive Settings configuration management - Simplify Dockerfile with uv image and alembic migrations - Update authentication and JWT handling - Add environment configuration examples - Remove deprecated Configuration.py in favor of Settings.py - Update mail client and event router implementations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
| @classmethod | ||
| def password_validation(cls, v): | ||
| if (re.search("^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\w\W]{8,}$", v) | ||
| if (re.search(r"^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\w\W]{8,}$", v) |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
Suspicious character range that overlaps with \w in the same character class.
| @classmethod | ||
| def password_validation(cls, v): | ||
| if (re.search("^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\w\W]{8,}$", v) | ||
| if (re.search(r"^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\w\W]{8,}$", v) |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
Suspicious character range that overlaps with \w in the same character class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the project's configuration management, development workflow, and deployment processes. The main highlights are the migration from YAML-based configuration to environment variables, the adoption of new tools for code quality and formatting, and a modernization of deployment and Dockerization strategies.
Configuration and Environment Management:
.env.exampleas a template and documented the process inREADME-config.md. [1] [2].envfile for the main backend environment, and updated code to useSettingsfor configuration access instead of the oldConfigurationclass. [1] [2] [3]Development Workflow Enhancements:
.pre-commit-config.yamlto enforce code formatting and linting withruffviauv, replacing previous tools..github/workflows/code-quality.ymlfor automated linting and formatting, and removed obsolete workflows for formatting and pylint. [1] [2] [3]3.12in.python-versionfor consistency across tooling.Deployment and Dockerization:
.github/workflows/deploy.yml, improving error handling, dependency management (switching touv), and logging. The previous deployment workflow.github/workflows/deployVPS.ymlwas removed. [1] [2]Dockerfileto use theuvPython 3.12 image, install dependencies withuv, and improve build and run commands.Codebase Modernization:
Settingsinstead ofConfiguration). [1] [2] [3] [4] [5]App.pyand migration scripts. [1] [2] [3] [4]These changes collectively modernize the project, making configuration more secure and manageable, streamlining development and deployment workflows, and ensuring a more maintainable codebase.