Repository navigation
fix: render Codex file citations as file cards - #1706
Conversation
Model: gpt-6
Model: gpt-6
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c81917225
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Desktop PR smoke regression failed on commit
Recordings not attached
The Actions artifact retains the complete trace, screenshots, logs, and runtime evidence. |
Address citation review and CI failures; pin smoke builds to the CLI heap budget. Model: gpt-6
Related issue
No linked issue; same-repository fix.
Problem / pressure
Codex output references such as
:codex-file-citation{path="/tmp/report.xlsx" purpose="output" artifact_kind="workbook"}appear as raw directive text instead of usable file cards.Summary
The CI repair also removes a duplicate fixture key already present on main and runs
CLI and desktop builds in separate smoke-workflow steps, preserving each build's
existing memory budget.
Visual explanation
Before / after
Test plan
markdown-agent-file-link,markdown-streaming-reparse, andsession-file-card, including Windows paths, card clicks, and inline/display math.pnpm check:quick(type-aware lint and repository boundary checks).NODE_OPTIONS=--max-old-space-size=2048; desktopbuild:appwith its existing renderer heap budget. Both builds include their type checks.pnpm run docs checkwith initialized submodules (zero errors), targeted Oxfmt, andgit diff --check.33015d132; desktop smoke execution is tracked in the PR Checks tab. Local evidence and remote results are distinct.