Repository navigation
feat: add project default MCP settings across UI and session authoring - #1708
Merged
Merged
Conversation
Model: gpt-6
Model: gpt-6
Model: gpt-6-astra
Expose project MCP defaults from the shared catalog room, with loaded and failed states. Add an authorized project-default writer that checks authority, workspace scope and ids at the write, resolves on local durability, and never fails on upload. Add a Default MCP tab after Skills in the project window. Landing, draft and existing-session composers now use the scoped selection. New conversations preselect target-project defaults and wait until those defaults are read. Existing conversations keep their recorded ids, and unrecorded ones stay empty. Edits reset in the same render when the workspace or project changes. Sends carry the selection captured at click time. Model: claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model: claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model: gpt-6-astra
Preserve attachment inputs, frozen run-config provenance and current catalog ownership while resolving project-default conflicts. Model: gpt-6-astra
Model: gpt-6-astra
Model: gpt-6-astra
Remove the single-consumer settings hook, redundant model and memo wrappers, duplicate save-state error handling, and a test-only exported Flock writer. Preserve readiness and authorization; add failed-write recovery coverage. Model: gpt-6-astra
Model: gpt-6-astra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No linked issue; internal feature request.
Problem / pressure
Projects need reusable MCP selections. Resolve defaults at turn authoring so settings changes cannot alter accepted work.
Summary
Add a Default MCP tab after Skills in desktop project settings, with switches and loading, failure, missing-connection and read-only states. Workspace Flock stores one ids array per project: absence inherits workspace defaults; a present array replaces them; [] turns all off. Branches/worktrees share project identity.
Landing, draft and existing-session composers use scoped selection and click-time snapshots. CLI and single/batch MCP creation resolve target-project defaults; continuation retains the target selection. Explicit ids override either path. Existing Operation configuration freezes ids for retry/recovery; runtime consumes only turn ids.
UI writes check project authority and workspace scope, commit locally, then upload best-effort. UI Designer's UI and translations are integrated. Latest main is merged, preserving attachments, run-config provenance and Operation origin metadata. Bilingual Specs remain draft; the architecture note records implementation, limits and ablation evidence.
Ablation removed the single-consumer settings hook/model, memo wrappers, duplicate save/error state, and a project-row write helper with no production consumer: 70 fewer production lines. The Tab now owns edit state directly. Removing the readiness gate caused three behavioral failures, so that guard is retained. Failed-save recovery coverage was added.
Visual explanation
Before / after
Projects previously had no default MCP setting, and CLI/MCP turns omitted selection. New conversations preselect defaults; existing conversations retain their selection, including []. Customized projects stop inheriting later workspace-default additions.
Test plan
PR remains draft pending human review.