Repository Organization - #67
Open
JonahBlackmon wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the
merge-testingbranch and aims to cleanup index.tsx from ~1000 lines down to 273. This removed most responsibilities from the file and separated them into distinct files located within the newsrc/folder.Functionality:
In
~/src/features/map/useMapScreenController.tsthere is now a main controller for the app, within this controller there are references to objects responsible for searching and reporting which can be accessed inindex.tsxviamap.reportandmap.searchrespectively. This allows for changes to be made in isolation while keeping a clear flow of control. Additional features need simply to be added to the controller and will be able to be used.I plan on following up this PR with a dedicated PR for documentation which will outline how the new organization structure works in greater detail, but for the sake of progress, this can be postponed to allow others to continue developing.