Repository navigation
Announce a pump fault and release the handles waiting on it - #129
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 85.58% 85.59% +0.01%
==========================================
Files 147 147
Lines 35323 35361 +38
Branches 35323 35361 +38
==========================================
+ Hits 30230 30267 +37
- Misses 3410 3414 +4
+ Partials 1683 1680 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



When the client's background driver hit an error that was not a lost connection, it stopped without telling anyone. No event went out, the socket stayed open, and everything waiting on the client kept waiting for good, a live query's
changed(), a content ticket, the file client's heal loop. An application had no way to show that sync had died.Such an error now ends the driver the way a close does, except that the application first receives
ClientEvent::Stoppedcarrying the error's text, then the usualClosed, so everything that already settles onClosedsettles. Live handles returnClientError::Stoppedfromchanged(), while their rows andwith_connkeep working on the local copy, as afterclose(). The three demos show the message in their status line.The new test in
crates/connetto-client/tests/it/pump_fault.rsfeeds the client a live patch that cannot be decoded. Onmainit waits out its five-second bound with no event at all, and here it seesStoppedthenClosed, the waiting handle released and the socket closed.