Skip to content

Announce a pump fault and release the handles waiting on it - #129

Open
LucaCappelletti94 wants to merge 1 commit into
mainfrom
fix/pump-silent-stop
Open

LucaCappelletti94 wants to merge 1 commit into
mainfrom
fix/pump-silent-stop

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Owner

When the client's background driver hit an error that was not a lost connection, it stopped without telling anyone. No event went out, the socket stayed open, and everything waiting on the client kept waiting for good, a live query's changed(), a content ticket, the file client's heal loop. An application had no way to show that sync had died.

Such an error now ends the driver the way a close does, except that the application first receives ClientEvent::Stopped carrying the error's text, then the usual Closed, so everything that already settles on Closed settles. Live handles return ClientError::Stopped from changed(), while their rows and with_conn keep working on the local copy, as after close(). The three demos show the message in their status line.

The new test in crates/connetto-client/tests/it/pump_fault.rs feeds the client a live patch that cannot be decoded. On main it waits out its five-second bound with no event at all, and here it sees Stopped then Closed, the waiting handle released and the socket closed.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: adf84a69-74ba-45af-8666-8a5e9986f7b9
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 5, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 49.05660% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.59%. Comparing base (ded95a2) to head (d2a2961).

Files with missing lines Patch % Lines
crates/connetto-client/src/live.rs 49.05% 25 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   85.58%   85.59%   +0.01%     
==========================================
  Files         147      147              
  Lines       35323    35361      +38     
  Branches    35323    35361      +38     
==========================================
+ Hits        30230    30267      +37     
- Misses       3410     3414       +4     
+ Partials     1683     1680       -3     
Flag Coverage Δ
client 55.18% <49.05%> (+0.02%) ⬆️
rest 53.22% <3.77%> (-0.32%) ⬇️
server 53.26% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant