Run rusqlite's SQLite3MC tests on the vendored amalgamation in CI - #10
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 3 3
Branches 3 3
=========================================
Hits 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8b521a1 to
663e653
Compare
|



sqlite3mc-srcexists to feed thebundled-sqlite3mcfeature oflibsqlite3-sys, yet CI never built that consumer on the bytes under review. A SQLite3MC release that drops or renames a function the committedrusqlitebindings declare would pass every check here and break only when someone builtrusqlite.The new
rusqlitejob fetches thefeat/sqlite3mc-srcbranch ofLucaCappelletti94/rusqliteat one pinned commit, points itssqlite3mc-srcdependency at this checkout and runsrusqlite's tests with the feature sets that branch runs, including abuildtime_bindgenpass that regenerates the bindings from the shipped header. The branch requires one exactsqlite3mc-srcrelease, and Cargo silently drops a patch whose version misses it, so the job rewrites that requirement to the checkout's version and ends by checking that the build output names this checkout'ssqlite3mcdirectory. Without both, a release-bot PR would test the old crates.io bytes and pass.A weekly
rusqlite pinworkflow goes red when the fork branch moves past the pinned commit or when a releasedrusqlitegainsbundled-sqlite3mc, so the pin moves to a released coordinate as soon as one exists.