perf(ds4): unify gfx1151 sparse-prefill stack - #685
Draft
davide221 wants to merge 13 commits into
Draft
Conversation
10 tasks
Contributor
Author
|
PR58 integration revalidation found that this unified draft still carries several unresolved correctness issues from the Cubic reviews on its #664/#667 ancestors. I verified them against
The branch is already marked draft, which is correct. For any matched throughput result, please either fix these paths or explicitly disable the affected switches and record that environment; otherwise the speed number is not yet a merge/quality-qualified result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Draft integration branch. Do not merge until a matched 8K/32K/128K qualification runs on the 128 GiB Strix Halo target.
Composition
main, including merged perf(ds4): enable sparse gate-up MMQ prefill #673 sparse gate/up MMQ prefill;The commits are replayed rather than percentage-stacked. Existing measurements from divergent branches are not added together.
Validation completed
Physical gfx1151 / ROCm HIP build on Lucebox Cina:
dflash_serverbuilds;test_deepseek4_unit: pass;test_deepseek4_mmid_grouped_cuda: 76/76 parity cases pass;test_server_unit: 455/455 pass;test_feature_gate: 1/1 pass.The composed streaming-attention microbenchmark measured 2613.4 us for the grouped path and 2079.0 us for FP32-staged streaming MLA with fast exp: 1.26x kernel speedup, NMSE 1.97e-14 and max absolute error 4.1e-8 versus the precise path.
Existing full-model evidence, not a unified result
Qualification switches
The first matched run should preserve the deployed release settings and additionally test:
DFLASH_DS4_DIRECT_INDEXER_TOPK=1GGML_CUDA_MLA_STREAM_TOPK=1GGML_CUDA_MLA_STREAM_F32_STAGE=1GGML_CUDA_MLA_STREAM_FAST_EXP=1GGML_CUDA_MMQ_MOE_ADAPTIVE_X=1GGML_CUDA_MMQ_MOE_PERSISTENT=1DFLASH_DS4_LONG_CONTEXT_CHUNK=8192Each switch remains independently killable until the full-model matrix is complete.