Fix compatibility with ComfyUI 0.3.76#13
Open
sw-dkreider wants to merge 1 commit intoLucipherDev:mainfrom
Open
Fix compatibility with ComfyUI 0.3.76#13sw-dkreider wants to merge 1 commit intoLucipherDev:mainfrom
sw-dkreider wants to merge 1 commit intoLucipherDev:mainfrom
Conversation
ComfyUI 0.3.76 introduced breaking changes to the PromptQueue API: 1. `task_done()` now accepts an additional `process_item` parameter 2. `get_current_queue_volatile()` is used by server.py for the /queue endpoint 3. Queue items returned must be in tuple format for slicing (x[:5]) Changes: - Add `process_item=None` parameter to `user_queue_task_done()` - Override `get_current_queue_volatile` in addition to `get_current_queue` - Unwrap Sentinel's dict format back to original tuple format in queue getter Without these fixes, ComfyUI 0.3.76 throws: - TypeError: user_queue_task_done() got unexpected keyword argument 'process_item' - TypeError: unhashable type: 'slice' (when accessing /queue endpoint)
|
Hello, @sw-dkreider, I have created a fork of sentinel which resolved this issue and have begun adding many additional features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes compatibility issues with ComfyUI 0.3.76, which introduced breaking changes to the
PromptQueueAPI.Changes
process_itemparameter touser_queue_task_done()- ComfyUI 0.3.76 now passes this additional argumentget_current_queue_volatile- The/queueendpoint now uses this method instead ofget_current_queueserver.pyProblem
Without these fixes, ComfyUI 0.3.76 throws:
TypeError: user_queue_task_done() got unexpected keyword argument 'process_item'TypeError: unhashable type: 'slice'(when accessing /queue endpoint)Testing
Tested with ComfyUI 0.3.76 (Revision 4297) on NVIDIA RTX PRO 6000 Blackwell. Queue operations, job execution, and user isolation all work correctly.