Repository navigation
fix(ci): deploy Workers before uploading branch previews - #18
Closed
imconnorngl wants to merge 1 commit into
Closed
imconnorngl wants to merge 1 commit into
imconnorngl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run a full Worker deployment before uploading branch previews so the Worker exists and its observability settings are applied. Branches other than
devthen upload an aliased, tagged preview version usingcloudflare/wrangler-action@v3.Type of Change
Changes Made
deploy --no-x-provisionfor both production and development.CLOUDFLARE_ENVpreflight check; the selected GitHub environment must still configure this variable.Testing
pnpm exec oxfmt --check .github/workflows/deploy-workers.yml.git diff --check.--yesflag.pnpm lintstops on an existing formatting issue in unchangedCLAUDE.md.Deployment Notes
devusescloudflare-production; other branches usecloudflare-development. Each GitHub environment must supplyCLOUDFLARE_ENV,CLOUDFLARE_API_TOKEN, andCLOUDFLARE_ACCOUNT_ID.