Skip to content

Conversation

@adrianschmidt
Copy link
Contributor

@adrianschmidt adrianschmidt commented Jan 20, 2026

Work around Stencil v4 e2e test parallelization issues that cause random timeouts in CI but not locally. Changes only apply when CI=true.

  • Add --disable-gpu browser arg in stencil.config.ts
  • Add --max-workers=2 in run-tests.cjs

See: stenciljs/core#6157

Summary by CodeRabbit

  • Chores
    • Optimized test execution performance in continuous integration environments
    • Enhanced test stability by adjusting resource allocation for parallel test runs
    • Improved debugging diagnostics with additional logging during test execution

✏️ Tip: You can customize this high-level summary in your review settings.

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Both files are modified to optimize testing behavior in CI environments by conditionally disabling GPU and reducing test parallelism, along with enhanced debug logging. The changes use environment variable detection to apply CI-specific test configurations.

Changes

Cohort / File(s) Summary
CI Test Optimization
scripts/run-tests.cjs, stencil.config.ts
Added conditional CI detection via environment variable. When CI is active, run-tests.cjs now reduces test parallelism to 2 workers and logs debug mode enablement. stencil.config.ts conditionally appends --disable-gpu flag to browserArgs to mitigate parallelization issues in CI.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: reducing e2e test parallelism in CI to fix flaky tests, which is the core objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-flaky-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adrianschmidt
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions
Copy link

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3789/

@adrianschmidt
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@adrianschmidt
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@scripts/run-tests.cjs`:
- Around line 20-25: Update the comment above the CI parallelism adjustment to
accurately reflect the library version or intent: change the mention of "Stencil
v4" to "Stencil v3.4.2" (or note that this is a forward-looking workaround for
potential Stencil v4 issues) so the comment matches the project context; the
change should be made in the block that checks isCI and pushes '--max-workers=2'
(see the isCI condition, args.push('--max-workers=2') and the console.log
statement) to avoid version confusion.

In `@stencil.config.ts`:
- Around line 52-57: The browserArgs spread uses a simple truthy check on
process.env.CI which is inconsistent with run-tests.cjs; change the conditional
to use the shared helper envIsSet('CI') (the same function used in
run-tests.cjs) so edge cases like '0'/'false' are handled consistently, and add
the corresponding import for envIsSet at the top of stencil.config.ts; update
the spread expression in browserArgs to use envIsSet('CI') instead of
process.env.CI.

Work around Stencil v4 e2e test parallelization issues that cause
random timeouts in CI but not locally. Changes only apply when CI=true.

- Add --disable-gpu browser arg in stencil.config.ts
- Add --max-workers=2 in run-tests.cjs

See: stenciljs/core#6157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants