-
Notifications
You must be signed in to change notification settings - Fork 16
ci(testing): reduce e2e test parallelism in CI to fix flaky tests #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: add-verbose-test-logging
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughBoth files are modified to optimize testing behavior in CI environments by conditionally disabling GPU and reducing test parallelism, along with enhanced debug logging. The changes use environment variable detection to apply CI-specific test configurations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3789/ |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@scripts/run-tests.cjs`:
- Around line 20-25: Update the comment above the CI parallelism adjustment to
accurately reflect the library version or intent: change the mention of "Stencil
v4" to "Stencil v3.4.2" (or note that this is a forward-looking workaround for
potential Stencil v4 issues) so the comment matches the project context; the
change should be made in the block that checks isCI and pushes '--max-workers=2'
(see the isCI condition, args.push('--max-workers=2') and the console.log
statement) to avoid version confusion.
In `@stencil.config.ts`:
- Around line 52-57: The browserArgs spread uses a simple truthy check on
process.env.CI which is inconsistent with run-tests.cjs; change the conditional
to use the shared helper envIsSet('CI') (the same function used in
run-tests.cjs) so edge cases like '0'/'false' are handled consistently, and add
the corresponding import for envIsSet at the top of stencil.config.ts; update
the spread expression in browserArgs to use envIsSet('CI') instead of
process.env.CI.
Work around Stencil v4 e2e test parallelization issues that cause random timeouts in CI but not locally. Changes only apply when CI=true. - Add --disable-gpu browser arg in stencil.config.ts - Add --max-workers=2 in run-tests.cjs See: stenciljs/core#6157
98ef990 to
e0117c3
Compare
5f17bdc to
e0117c3
Compare
Work around Stencil v4 e2e test parallelization issues that cause random timeouts in CI but not locally. Changes only apply when CI=true.
See: stenciljs/core#6157
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: